Mirror/libcamera
1
0
Fork 0
mirror of https://git.libcamera.org/libcamera/libcamera.git synced 2025-07-25 17:45:06 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

pipeline: rkisp1: Move ControlInfoMap to IPA module

Browse source 
Currently the pipeline handler advertises controls handled by the IPA
from a ControlInfoMap it manually constructs. This is wrong, as the IPA
module is the component that knows what controls it supports. Fix this
by moving the ControlInfoMap construction to the IPA module, and pass it
to the pipeline handler as a return value from the IPA init() function.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Florian Sylvestre <fsylvestre@baylibre.com>
This commit is contained in:
Laurent Pinchart 2022-08-02 02:28:44 +03:00
parent 502ab9a146
commit 961a6cf7ca
3 changed files with 30 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

2
include/libcamera/ipa/rkisp1.mojom
View file

@ -11,7 +11,7 @@ import "include/libcamera/ipa/core.mojom";
interface IPARkISP1Interface {
init(libcamera.IPASettings settings,
uint32 hwRevision)
=> (int32 ret);
=> (int32 ret, libcamera.ControlInfoMap ipaControls);
start() => (int32 ret);
stop();