Mirror/libcamera
1
0
Fork 0
mirror of https://git.libcamera.org/libcamera/libcamera.git synced 2025-07-15 16:35:06 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

libcamera: ipu3: Set stream configuration

Browse source 
Use the cached sensor maximum resolution and the pixel format
generated by the ImgU output devices as default stream configuration.

While at it, replace the hardcoded numerical value for the number of
buffers with a named constexpr.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
This commit is contained in:
Jacopo Mondi 2019-02-27 13:37:11 +01:00
parent 4ce2f06a1b
commit 9a1cdb7500
1 changed files with 13 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

30
src/libcamera/pipeline/ipu3/ipu3.cpp
View file

@ -169,6 +169,8 @@ private:
Stream stream_;
};
static constexpr unsigned int IPU3_BUFFER_COUNT = 4;
IPU3CameraData *cameraData(const Camera *camera)
{
return static_cast<IPU3CameraData *>(
@ -201,26 +203,20 @@ std::map<Stream *, StreamConfiguration>
PipelineHandlerIPU3::streamConfiguration(Camera *camera,
std::set<Stream *> &streams)
{
IPU3CameraData *data = cameraData(camera);
std::map<Stream *, StreamConfiguration> configs;
V4L2SubdeviceFormat format = {};
IPU3CameraData *data = cameraData(camera);
StreamConfiguration *config = &configs[&data->stream_];
Size *maxSize = &data->.cio2_.maxSize_;
/*
* FIXME: As of now, return the image format reported by the sensor.
* In future good defaults should be provided for each stream.
*/
if (data->cio2_.sensor_->getFormat(0, &format)) {
LOG(IPU3, Error) << "Failed to create stream configurations";
return configs;
}
config->width = maxSize->width;
config->height = maxSize->height;
config->pixelFormat = V4L2_PIX_FMT_NV12;
config->bufferCount = IPU3_BUFFER_COUNT;
StreamConfiguration config = {};
config.width = format.width;
config.height = format.height;
config.pixelFormat = V4L2_PIX_FMT_IPU3_SGRBG10;
config.bufferCount = 4;
configs[&data->stream_] = config;
LOG(IPU3, Debug)
<< "Stream format set to " << config->width << "x"
<< config->height << "-0x" << std::hex << std::setfill('0')
<< std::setw(8) << config->pixelFormat;
return configs;
}