Mirror/libcamera
1
0
Fork 0
mirror of https://git.libcamera.org/libcamera/libcamera.git synced 2025-07-18 18:05:09 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

libcamera: pipeline: rpi: Do not clear request metadata anymore

Browse source 
Since 6cf9c4d34f ("pipeline: ipa: rpi: Split RPiCameraData::dropFrameCount_")
the initial n frames are not dropped anymore. So clearing the request metadata
should not be necessary anymore, remove it.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Reviewed-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
This commit is contained in:
Barnabás Pőcze 2025-06-25 15:08:21 +02:00
parent 305d73cd2c
commit c0586867a9
2 changed files with 2 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/libcamera/pipeline/rpi/pisp/pisp.cpp
View file

@ -2313,16 +2313,11 @@ void PiSPCameraData::tryRunPipeline()
/* Take the first request from the queue and action the IPA. */ /* Take the first request from the queue and action the IPA. */
Request *request = requestQueue_.front(); Request *request = requestQueue_.front();
ASSERT(request->metadata().empty());
/* See if a new ScalerCrop value needs to be applied. */ /* See if a new ScalerCrop value needs to be applied. */
applyScalerCrop(request->controls()); applyScalerCrop(request->controls());
/*
* Clear the request metadata and fill it with some initial non-IPA
* related controls. We clear it first because the request metadata
* may have been populated if we have dropped the previous frame.
*/
request->metadata().clear();
fillRequestMetadata(job.sensorControls, request); fillRequestMetadata(job.sensorControls, request);
/* Set our state to say the pipeline is active. */ /* Set our state to say the pipeline is active. */

7
src/libcamera/pipeline/rpi/vc4/vc4.cpp
View file

@ -927,16 +927,11 @@ void Vc4CameraData::tryRunPipeline()
/* Take the first request from the queue and action the IPA. */ /* Take the first request from the queue and action the IPA. */
Request *request = requestQueue_.front(); Request *request = requestQueue_.front();
ASSERT(request->metadata().empty());
/* See if a new ScalerCrop value needs to be applied. */ /* See if a new ScalerCrop value needs to be applied. */
applyScalerCrop(request->controls()); applyScalerCrop(request->controls());
/*
* Clear the request metadata and fill it with some initial non-IPA
* related controls. We clear it first because the request metadata
* may have been populated if we have dropped the previous frame.
*/
request->metadata().clear();
fillRequestMetadata(bayerFrame.controls, request); fillRequestMetadata(bayerFrame.controls, request);
/* Set our state to say the pipeline is active. */ /* Set our state to say the pipeline is active. */