Mirror/libcamera
1
0
Fork 0
mirror of https://git.libcamera.org/libcamera/libcamera.git synced 2025-07-13 15:29:45 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

py: gen-py-controls: Remove SceneFlicker workaround

Browse source 
The python bindings layer has to parse the libcamera controls to ensure
that they are converted to suitable names for the python layer.

Part of this strips out common prefixes from control names, however the
SceneFlicker control would end up using an illegal name if processed in
the same way as the other controls.

The SceneFlicker control has now been removed as part of the
introduction of the AeFlickerMode and AeFlickerPeriod controls.

Remove the workaround in the python layer.

Fixes: 6fdbf3f38c ("libcamera: controls: Add controls for AEC/AGC flicker avoidance")
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: David Plowman <david.plowman@raspberrypi.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Kieran Bingham 2023-07-25 13:56:40 +01:00
parent d05009d34c
commit c258302863
1 changed files with 0 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/py/libcamera/gen-py-controls.py
View file

@ -48,9 +48,6 @@ def generate_py(controls, mode):
# Adjustments for controls # Adjustments for controls
if name == 'LensShadingMapMode': if name == 'LensShadingMapMode':
prefix = 'LensShadingMapMode' prefix = 'LensShadingMapMode'
elif name == 'SceneFlicker':
# If we strip the prefix, we would get '50Hz', which is illegal name
prefix = ''
else: else:
prefix = find_common_prefix([e['name'] for e in enum]) prefix = find_common_prefix([e['name'] for e in enum])
else: else: