Mirror/libcamera
1
0
Fork 0
mirror of https://git.libcamera.org/libcamera/libcamera.git synced 2025-07-15 16:35:06 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

libcamera: ipu3: Make it easier to read when a request may be completed

Browse source 
It's confusing to read the code and understand that a request is only
completed before being processed by the ImgU if it only contains a
single RAW buffer. Add a boolean variable with a explanatory name to
make this clearer, no functional change.

Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Niklas Söderlund 2020-06-29 17:14:13 +02:00
parent 8e137b0819
commit c3648da6e9
1 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/libcamera/pipeline/ipu3/ipu3.cpp
View file

@ -874,10 +874,12 @@ void IPU3CameraData::cio2BufferReady(FrameBuffer *buffer)
* If the request contains a buffer for the RAW stream only, complete it
* now as there's no need for ImgU processing.
*/
if (request->findBuffer(&rawStream_) &&
pipe_->completeBuffer(camera_, request, buffer)) {
pipe_->completeRequest(camera_, request);
return;
if (request->findBuffer(&rawStream_)) {
bool isComplete = pipe_->completeBuffer(camera_, request, buffer);
if (isComplete) {
pipe_->completeRequest(camera_, request);
return;
}
}
imgu_->input_->queueBuffer(buffer);