Mirror/libcamera
1
0
Fork 0
mirror of https://git.libcamera.org/libcamera/libcamera.git synced 2025-07-14 16:09:51 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

android: jpeg: encoder: Use pass-by-value for Exif parameter

Browse source 
Following the reasoning of pass-by-value for libcamera::Span
parameters from 90c193f2a700("android: Modify Encoder interface") i.e.
they are easy to copy/move/construct, align the Exif parameter passing
to the encoder interface in this consistent way.

Signed-off-by: Umang Jain <email@uajain.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Umang Jain 2020-10-23 11:01:50 +05:30 • committed by Laurent Pinchart
parent f9e7f55f3b
commit c430d39d20
3 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/android/jpeg/encoder.h
View file

@ -19,7 +19,7 @@ public:
virtual int configure(const libcamera::StreamConfiguration &cfg) = 0; virtual int configure(const libcamera::StreamConfiguration &cfg) = 0;
virtual int encode(const libcamera::FrameBuffer &source, virtual int encode(const libcamera::FrameBuffer &source,
libcamera::Span<uint8_t> destination, libcamera::Span<uint8_t> destination,
const libcamera::Span<const uint8_t> &exifData) = 0; libcamera::Span<const uint8_t> exifData) = 0;
}; };
#endif /* __ANDROID_JPEG_ENCODER_H__ */ #endif /* __ANDROID_JPEG_ENCODER_H__ */

2
src/android/jpeg/encoder_libjpeg.cpp
View file

@ -180,7 +180,7 @@ void EncoderLibJpeg::compressNV(const MappedBuffer *frame)
} }
int EncoderLibJpeg::encode(const FrameBuffer &source, Span<uint8_t> dest, int EncoderLibJpeg::encode(const FrameBuffer &source, Span<uint8_t> dest,
const Span<const uint8_t> &exifData) Span<const uint8_t> exifData)
{ {
MappedFrameBuffer frame(&source, PROT_READ); MappedFrameBuffer frame(&source, PROT_READ);
if (!frame.isValid()) { if (!frame.isValid()) {

2
src/android/jpeg/encoder_libjpeg.h
View file

@ -23,7 +23,7 @@ public:
int configure(const libcamera::StreamConfiguration &cfg) override; int configure(const libcamera::StreamConfiguration &cfg) override;
int encode(const libcamera::FrameBuffer &source, int encode(const libcamera::FrameBuffer &source,
libcamera::Span<uint8_t> destination, libcamera::Span<uint8_t> destination,
const libcamera::Span<const uint8_t> &exifData) override; libcamera::Span<const uint8_t> exifData) override;
private: private:
void compressRGB(const libcamera::MappedBuffer *frame); void compressRGB(const libcamera::MappedBuffer *frame);