libcamera/base: Move utils to the base library

Move the utils functionality to the libcamera/base library.

Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

include/libcamera/base/meson.build

@@ -3,6 +3,7 @@
 libcamera_base_include_dir = libcamera_include_dir / 'base'
 
 libcamera_base_headers = files([
+    'utils.h',
 ])
 
 install_headers(libcamera_base_headers,

include/libcamera/base/utils.h

@@ -4,8 +4,8 @@
  *
  * utils.h - Miscellaneous utility functions
  */
-#ifndef __LIBCAMERA_INTERNAL_UTILS_H__
-#define __LIBCAMERA_INTERNAL_UTILS_H__
+#ifndef __LIBCAMERA_BASE_UTILS_H__
+#define __LIBCAMERA_BASE_UTILS_H__
 
 #include <algorithm>
 #include <chrono>
@@ -23,7 +23,7 @@
 
 /* uClibc and uClibc-ng don't provide O_TMPFILE */
 #ifndef O_TMPFILE
-#define O_TMPFILE	(020000000 | O_DIRECTORY)
+#define O_TMPFILE (020000000 | O_DIRECTORY)
 #endif
 
 #endif
@@ -352,4 +352,4 @@ std::basic_ostream<CharT, Traits> &operator<<(std::basic_ostream<CharT, Traits>
 
 } /* namespace libcamera */
 
-#endif /* __LIBCAMERA_INTERNAL_UTILS_H__ */
+#endif /* __LIBCAMERA_BASE_UTILS_H__ */

include/libcamera/internal/log.h

@@ -12,7 +12,7 @@
 
 #include <libcamera/class.h>
 
-#include "libcamera/internal/utils.h"
+#include <libcamera/base/utils.h>
 
 namespace libcamera {
 

include/libcamera/internal/meson.build

@@ -43,7 +43,6 @@ libcamera_internal_headers = files([
     'sysfs.h',
     'thread.h',
     'timer.h',
-    'utils.h',
     'v4l2_device.h',
     'v4l2_pixelformat.h',
     'v4l2_subdevice.h',

include/libcamera/internal/thread.h

@@ -14,8 +14,9 @@
 
 #include <libcamera/signal.h>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/message.h"
-#include "libcamera/internal/utils.h"
 
 namespace libcamera {
 

src/android/camera_device.cpp

@@ -20,9 +20,10 @@
 #include <libcamera/formats.h>
 #include <libcamera/property_ids.h>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/log.h"
 #include "libcamera/internal/thread.h"
-#include "libcamera/internal/utils.h"
 
 #include "system/graphics.h"
 

src/android/jpeg/exif.cpp

@@ -14,8 +14,9 @@
 #include <tuple>
 #include <uchar.h>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/log.h"
-#include "libcamera/internal/utils.h"
 
 using namespace libcamera;
 

src/ipa/ipu3/ipu3_agc.h

@@ -12,9 +12,9 @@
 
 #include <linux/intel-ipu3.h>
 
-#include <libcamera/geometry.h>
+#include <libcamera/base/utils.h>
 
-#include "libcamera/internal/utils.h"
+#include <libcamera/geometry.h>
 
 #include "libipa/algorithm.h"
 

src/ipa/raspberrypi/cam_helper.hpp

@@ -15,7 +15,8 @@
 #include "controller/metadata.hpp"
 #include "md_parser.hpp"
 
-#include "libcamera/internal/utils.h"
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/v4l2_videodevice.h"
 
 namespace RPiController {

src/ipa/raspberrypi/controller/agc_algorithm.hpp

@@ -6,7 +6,8 @@
  */
 #pragma once
 
-#include "libcamera/internal/utils.h"
+#include <libcamera/base/utils.h>
+
 #include "algorithm.hpp"
 
 namespace RPiController {

src/ipa/raspberrypi/controller/agc_status.h

@@ -6,7 +6,7 @@
  */
 #pragma once
 
-#include "libcamera/internal/utils.h"
+#include <libcamera/base/utils.h>
 
 // The AGC algorithm should post the following structure into the image's
 // "agc.status" metadata.

src/ipa/raspberrypi/controller/camera_mode.h

@@ -8,7 +8,7 @@
 
 #include <libcamera/transform.h>
 
-#include "libcamera/internal/utils.h"
+#include <libcamera/base/utils.h>
 
 // Description of a "camera mode", holding enough information for control
 // algorithms to adapt their behaviour to the different modes of the camera,

src/ipa/raspberrypi/controller/device_status.h

@@ -6,7 +6,7 @@
  */
 #pragma once
 
-#include "libcamera/internal/utils.h"
+#include <libcamera/base/utils.h>
 
 // Definition of "device metadata" which stores things like shutter time and
 // analogue gain that downstream control algorithms will want to know.

src/ipa/raspberrypi/controller/rpi/agc.hpp

@@ -9,7 +9,7 @@
 #include <vector>
 #include <mutex>
 
-#include "libcamera/internal/utils.h"
+#include <libcamera/base/utils.h>
 
 #include "../agc_algorithm.hpp"
 #include "../agc_status.h"

src/ipa/raspberrypi/controller/rpi/lux.hpp

@@ -8,7 +8,7 @@
 
 #include <mutex>
 
-#include "libcamera/internal/utils.h"
+#include <libcamera/base/utils.h>
 
 #include "../lux_status.h"
 #include "../algorithm.hpp"

src/libcamera/base/meson.build

@@ -1,6 +1,7 @@
 # SPDX-License-Identifier: CC0-1.0
 
 libcamera_base_sources = files([
+    'utils.cpp',
 ])
 
 libcamera_base_deps = [

src/libcamera/base/utils.cpp

@@ -5,7 +5,7 @@
  * utils.cpp - Miscellaneous utility functions
  */
 
-#include "libcamera/internal/utils.h"
+#include <libcamera/base/utils.h>
 
 #include <iomanip>
 #include <sstream>
@@ -14,7 +14,7 @@
 #include <unistd.h>
 
 /**
- * \file utils.h
+ * \file base/utils.h
  * \brief Miscellaneous utility functions
  */
 
@@ -35,8 +35,8 @@ namespace utils {
  */
 const char *basename(const char *path)
 {
-       const char *base = strrchr(path, '/');
-       return base ? base + 1 : path;
+	const char *base = strrchr(path, '/');
+	return base ? base + 1 : path;
 }
 
 /**

src/libcamera/camera_manager.cpp

@@ -12,13 +12,14 @@
 
 #include <libcamera/camera.h>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/device_enumerator.h"
 #include "libcamera/internal/ipa_manager.h"
 #include "libcamera/internal/log.h"
 #include "libcamera/internal/pipeline_handler.h"
 #include "libcamera/internal/process.h"
 #include "libcamera/internal/thread.h"
-#include "libcamera/internal/utils.h"
 
 /**
  * \file camera_manager.h

src/libcamera/camera_sensor.cpp

@@ -18,11 +18,12 @@
 
 #include <libcamera/property_ids.h>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/bayer_format.h"
 #include "libcamera/internal/camera_sensor_properties.h"
 #include "libcamera/internal/formats.h"
 #include "libcamera/internal/sysfs.h"
-#include "libcamera/internal/utils.h"
 
 /**
  * \file camera_sensor.h

src/libcamera/controls.cpp

@@ -12,9 +12,10 @@
 #include <string>
 #include <string.h>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/control_validator.h"
 #include "libcamera/internal/log.h"
-#include "libcamera/internal/utils.h"
 
 /**
  * \file controls.h

src/libcamera/event_dispatcher_poll.cpp

@@ -16,11 +16,12 @@
 #include <sys/eventfd.h>
 #include <unistd.h>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/event_notifier.h"
 #include "libcamera/internal/log.h"
 #include "libcamera/internal/thread.h"
 #include "libcamera/internal/timer.h"
-#include "libcamera/internal/utils.h"
 
 /**
  * \file event_dispatcher_poll.h

src/libcamera/ipa_manager.cpp

@@ -12,12 +12,13 @@
 #include <string.h>
 #include <sys/types.h>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/file.h"
 #include "libcamera/internal/ipa_module.h"
 #include "libcamera/internal/ipa_proxy.h"
 #include "libcamera/internal/log.h"
 #include "libcamera/internal/pipeline_handler.h"
-#include "libcamera/internal/utils.h"
 
 /**
  * \file ipa_manager.h

src/libcamera/ipa_module.cpp

@@ -23,10 +23,11 @@
 
 #include <libcamera/span.h>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/file.h"
 #include "libcamera/internal/log.h"
 #include "libcamera/internal/pipeline_handler.h"
-#include "libcamera/internal/utils.h"
 
 /**
  * \file ipa_module.h

src/libcamera/ipa_proxy.cpp

@@ -12,9 +12,10 @@
 #include <sys/types.h>
 #include <unistd.h>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/ipa_module.h"
 #include "libcamera/internal/log.h"
-#include "libcamera/internal/utils.h"
 
 /**
  * \file ipa_proxy.h

src/libcamera/log.cpp

@@ -23,8 +23,9 @@
 
 #include <libcamera/logging.h>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/thread.h"
-#include "libcamera/internal/utils.h"
 
 /**
  * \file log.h

src/libcamera/meson.build

@@ -52,7 +52,6 @@ libcamera_sources = files([
     'thread.cpp',
     'timer.cpp',
     'transform.cpp',
-    'utils.cpp',
     'v4l2_device.cpp',
     'v4l2_pixelformat.cpp',
     'v4l2_subdevice.cpp',

src/libcamera/object.cpp

@@ -11,11 +11,12 @@
 
 #include <libcamera/signal.h>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/log.h"
 #include "libcamera/internal/message.h"
 #include "libcamera/internal/semaphore.h"
 #include "libcamera/internal/thread.h"
-#include "libcamera/internal/utils.h"
 
 /**
  * \file object.h

src/libcamera/pipeline/ipu3/imgu.cpp

@@ -16,9 +16,10 @@
 #include <libcamera/formats.h>
 #include <libcamera/stream.h>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/log.h"
 #include "libcamera/internal/media_device.h"
-#include "libcamera/internal/utils.h"
 
 namespace libcamera {
 

src/libcamera/pipeline/ipu3/ipu3.cpp

@@ -20,6 +20,8 @@
 #include <libcamera/request.h>
 #include <libcamera/stream.h>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/camera_sensor.h"
 #include "libcamera/internal/delayed_controls.h"
 #include "libcamera/internal/device_enumerator.h"
@@ -27,7 +29,6 @@
 #include "libcamera/internal/log.h"
 #include "libcamera/internal/media_device.h"
 #include "libcamera/internal/pipeline_handler.h"
-#include "libcamera/internal/utils.h"
 
 #include "cio2.h"
 #include "frames.h"

src/libcamera/pipeline/raspberrypi/raspberrypi.cpp

@@ -24,6 +24,8 @@
 #include <libcamera/property_ids.h>
 #include <libcamera/request.h>
 
+#include <libcamera/base/utils.h>
+
 #include <linux/bcm2835-isp.h>
 #include <linux/videodev2.h>
 
@@ -35,7 +37,6 @@
 #include "libcamera/internal/ipa_manager.h"
 #include "libcamera/internal/media_device.h"
 #include "libcamera/internal/pipeline_handler.h"
-#include "libcamera/internal/utils.h"
 #include "libcamera/internal/v4l2_videodevice.h"
 
 #include "dma_heaps.h"

src/libcamera/pipeline/rkisp1/rkisp1.cpp

@@ -24,6 +24,8 @@
 #include <libcamera/request.h>
 #include <libcamera/stream.h>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/camera_sensor.h"
 #include "libcamera/internal/delayed_controls.h"
 #include "libcamera/internal/device_enumerator.h"
@@ -31,7 +33,6 @@
 #include "libcamera/internal/log.h"
 #include "libcamera/internal/media_device.h"
 #include "libcamera/internal/pipeline_handler.h"
-#include "libcamera/internal/utils.h"
 #include "libcamera/internal/v4l2_subdevice.h"
 #include "libcamera/internal/v4l2_videodevice.h"
 

src/libcamera/pipeline/simple/converter.cpp

@@ -15,9 +15,10 @@
 #include <libcamera/signal.h>
 #include <libcamera/stream.h>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/log.h"
 #include "libcamera/internal/media_device.h"
-#include "libcamera/internal/utils.h"
 #include "libcamera/internal/v4l2_videodevice.h"
 
 namespace libcamera {

src/libcamera/pipeline/uvcvideo/uvcvideo.cpp

@@ -19,12 +19,13 @@
 #include <libcamera/request.h>
 #include <libcamera/stream.h>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/device_enumerator.h"
 #include "libcamera/internal/log.h"
 #include "libcamera/internal/media_device.h"
 #include "libcamera/internal/pipeline_handler.h"
 #include "libcamera/internal/sysfs.h"
-#include "libcamera/internal/utils.h"
 #include "libcamera/internal/v4l2_videodevice.h"
 
 namespace libcamera {

src/libcamera/pipeline/vimc/vimc.cpp

@@ -23,13 +23,14 @@
 #include <libcamera/request.h>
 #include <libcamera/stream.h>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/camera_sensor.h"
 #include "libcamera/internal/device_enumerator.h"
 #include "libcamera/internal/ipa_manager.h"
 #include "libcamera/internal/log.h"
 #include "libcamera/internal/media_device.h"
 #include "libcamera/internal/pipeline_handler.h"
-#include "libcamera/internal/utils.h"
 #include "libcamera/internal/v4l2_subdevice.h"
 #include "libcamera/internal/v4l2_videodevice.h"
 

src/libcamera/pipeline_handler.cpp

@@ -13,11 +13,12 @@
 #include <libcamera/camera.h>
 #include <libcamera/camera_manager.h>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/device_enumerator.h"
 #include "libcamera/internal/log.h"
 #include "libcamera/internal/media_device.h"
 #include "libcamera/internal/tracepoints.h"
-#include "libcamera/internal/utils.h"
 
 /**
  * \file pipeline_handler.h

src/libcamera/process.cpp

@@ -20,9 +20,10 @@
 #include <unistd.h>
 #include <vector>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/event_notifier.h"
 #include "libcamera/internal/log.h"
-#include "libcamera/internal/utils.h"
 
 /**
  * \file process.h

src/libcamera/source_paths.cpp

@@ -14,7 +14,7 @@
 #include <sys/stat.h>
 #include <sys/types.h>
 
-#include "libcamera/internal/utils.h"
+#include <libcamera/base/utils.h>
 
 /**
  * \file source_paths.h

src/libcamera/stream.cpp

@@ -15,8 +15,9 @@
 
 #include <libcamera/request.h>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/log.h"
-#include "libcamera/internal/utils.h"
 
 /**
  * \file stream.h

src/libcamera/timer.cpp

@@ -11,11 +11,12 @@
 
 #include <libcamera/camera_manager.h>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/event_dispatcher.h"
 #include "libcamera/internal/log.h"
 #include "libcamera/internal/message.h"
 #include "libcamera/internal/thread.h"
-#include "libcamera/internal/utils.h"
 
 /**
  * \file timer.h

src/libcamera/v4l2_device.cpp

@@ -16,10 +16,11 @@
 #include <sys/syscall.h>
 #include <unistd.h>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/event_notifier.h"
 #include "libcamera/internal/log.h"
 #include "libcamera/internal/sysfs.h"
-#include "libcamera/internal/utils.h"
 
 /**
  * \file v4l2_device.h

src/libcamera/v4l2_subdevice.cpp

@@ -19,10 +19,11 @@
 
 #include <libcamera/geometry.h>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/log.h"
 #include "libcamera/internal/media_device.h"
 #include "libcamera/internal/media_object.h"
-#include "libcamera/internal/utils.h"
 
 /**
  * \file v4l2_subdevice.h

src/v4l2/v4l2_camera_proxy.cpp

@@ -20,9 +20,10 @@
 #include <libcamera/formats.h>
 #include <libcamera/object.h>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/formats.h"
 #include "libcamera/internal/log.h"
-#include "libcamera/internal/utils.h"
 
 #include "v4l2_camera.h"
 #include "v4l2_camera_file.h"

src/v4l2/v4l2_compat_manager.cpp

@@ -22,8 +22,9 @@
 #include <libcamera/camera.h>
 #include <libcamera/camera_manager.h>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/log.h"
-#include "libcamera/internal/utils.h"
 
 #include "v4l2_camera_file.h"
 

test/camera-sensor.cpp

@@ -10,10 +10,11 @@
 
 #include <linux/media-bus-format.h>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/camera_sensor.h"
 #include "libcamera/internal/device_enumerator.h"
 #include "libcamera/internal/media_device.h"
-#include "libcamera/internal/utils.h"
 #include "libcamera/internal/v4l2_subdevice.h"
 
 #include "test.h"

test/file-descriptor.cpp

@@ -13,7 +13,7 @@
 
 #include <libcamera/file_descriptor.h>
 
-#include "libcamera/internal/utils.h"
+#include <libcamera/base/utils.h>
 
 #include "test.h"
 

test/ipc/unixsocket_ipc.cpp

@@ -15,6 +15,8 @@
 #include <sys/wait.h>
 #include <unistd.h>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/event_dispatcher.h"
 #include "libcamera/internal/ipa_data_serializer.h"
 #include "libcamera/internal/ipc_pipe.h"
@@ -22,7 +24,6 @@
 #include "libcamera/internal/process.h"
 #include "libcamera/internal/thread.h"
 #include "libcamera/internal/timer.h"
-#include "libcamera/internal/utils.h"
 
 #include "test.h"
 

test/log/log_process.cpp

@@ -16,12 +16,13 @@
 
 #include <libcamera/logging.h>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/event_dispatcher.h"
 #include "libcamera/internal/log.h"
 #include "libcamera/internal/process.h"
 #include "libcamera/internal/thread.h"
 #include "libcamera/internal/timer.h"
-#include "libcamera/internal/utils.h"
 
 #include "test.h"
 

test/pixel-format.cpp

@@ -10,7 +10,7 @@
 #include <libcamera/formats.h>
 #include <libcamera/pixel_format.h>
 
-#include "libcamera/internal/utils.h"
+#include <libcamera/base/utils.h>
 
 #include "test.h"
 

test/process/process_test.cpp

@@ -9,11 +9,12 @@
 #include <unistd.h>
 #include <vector>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/event_dispatcher.h"
 #include "libcamera/internal/process.h"
 #include "libcamera/internal/thread.h"
 #include "libcamera/internal/timer.h"
-#include "libcamera/internal/utils.h"
 
 #include "test.h"
 

test/signal-threads.cpp

@@ -9,9 +9,10 @@
 #include <iostream>
 #include <thread>
 
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/message.h"
 #include "libcamera/internal/thread.h"
-#include "libcamera/internal/utils.h"
 
 #include "test.h"
 

test/utils.cpp

@@ -14,7 +14,7 @@
 #include <libcamera/geometry.h>
 #include <libcamera/span.h>
 
-#include "libcamera/internal/utils.h"
+#include <libcamera/base/utils.h>
 
 #include "test.h"
 

test/v4l2_subdevice/list_formats.cpp

@@ -10,7 +10,8 @@
 
 #include <libcamera/geometry.h>
 
-#include "libcamera/internal/utils.h"
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/v4l2_subdevice.h"
 
 #include "v4l2_subdevice_test.h"

test/v4l2_videodevice/formats.cpp

@@ -8,7 +8,8 @@
 #include <iostream>
 #include <limits.h>
 
-#include "libcamera/internal/utils.h"
+#include <libcamera/base/utils.h>
+
 #include "libcamera/internal/v4l2_videodevice.h"
 
 #include "v4l2_videodevice_test.h"