Mirror/libcamera
1
0
Fork 0
mirror of https://git.libcamera.org/libcamera/libcamera.git synced 2025-07-16 00:45:07 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

libcamera: request: Make Request class Extensible

Browse source 
Implement the D-Pointer design pattern in the Request class to allow
changing internal data without affecting the public ABI.

Move the internal fields that are not needed to implement the public
API to the Request::Private class already. This allows to remove
the friend class declaration for the PipelineHandler class, which can
now use the Request::Private API.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
[Move all internal fields to Request::Private and remove friend  declaration]
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Laurent Pinchart 2021-10-18 14:54:31 +03:00 • committed by Jacopo Mondi
parent 6705596e29
commit db37335ee0
6 changed files with 219 additions and 108 deletions
Download patch file Download diff file Expand all files Collapse all files

19
include/libcamera/request.h
View file

@ -25,8 +25,10 @@ class CameraControlValidator;
class FrameBuffer;
class Stream;
class Request
class Request : public Extensible
{
LIBCAMERA_DECLARE_PRIVATE()
public:
enum Status {
RequestPending,
@ -52,34 +54,23 @@ public:
int addBuffer(const Stream *stream, FrameBuffer *buffer);
FrameBuffer *findBuffer(const Stream *stream) const;
uint32_t sequence() const { return sequence_; }
uint32_t sequence() const;
uint64_t cookie() const { return cookie_; }
Status status() const { return status_; }
bool hasPendingBuffers() const { return !pending_.empty(); }
bool hasPendingBuffers() const;
std::string toString() const;
private:
LIBCAMERA_DISABLE_COPY(Request)
friend class PipelineHandler;
void complete();
void cancel();
bool completeBuffer(FrameBuffer *buffer);
Camera *camera_;
ControlList *controls_;
ControlList *metadata_;
BufferMap bufferMap_;
std::unordered_set<FrameBuffer *> pending_;
uint32_t sequence_;
const uint64_t cookie_;
Status status_;
bool cancelled_;
};
} /* namespace libcamera */