mirror of
https://git.libcamera.org/libcamera/libcamera.git
synced 2025-07-15 16:35:06 +03:00
libcamera: stream: Rename StillCaptureRaw to Raw
With the buffer copy removed from all pipelines for raw capture rename StillCaptureRaw to Raw to better describe the role. Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> Reviewed-by: David Plowman <david.plowman@raspberrypi.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
This commit is contained in:
parent
b83ee94fe2
commit
dbe8d271e7
7 changed files with 10 additions and 11 deletions
|
@ -59,8 +59,8 @@ private:
|
|||
};
|
||||
|
||||
enum StreamRole {
|
||||
Raw,
|
||||
StillCapture,
|
||||
StillCaptureRaw,
|
||||
VideoRecording,
|
||||
Viewfinder,
|
||||
};
|
||||
|
|
|
@ -313,7 +313,7 @@ std::vector<Size> CameraDevice::getYUVResolutions(CameraConfiguration *cameraCon
|
|||
std::vector<Size> CameraDevice::getRawResolutions(const libcamera::PixelFormat &pixelFormat)
|
||||
{
|
||||
std::unique_ptr<CameraConfiguration> cameraConfig =
|
||||
camera_->generateConfiguration({ StillCaptureRaw });
|
||||
camera_->generateConfiguration({ StreamRole::Raw });
|
||||
StreamConfiguration &cfg = cameraConfig->at(0);
|
||||
const StreamFormats &formats = cfg.formats();
|
||||
std::vector<Size> supportedResolutions = formats.sizes(pixelFormat);
|
||||
|
@ -895,7 +895,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()
|
|||
|
||||
/* Report if camera supports RAW. */
|
||||
std::unique_ptr<CameraConfiguration> cameraConfig =
|
||||
camera_->generateConfiguration({ StillCaptureRaw });
|
||||
camera_->generateConfiguration({ StreamRole::Raw });
|
||||
if (cameraConfig && !cameraConfig->empty()) {
|
||||
const PixelFormatInfo &info =
|
||||
PixelFormatInfo::info(cameraConfig->at(0).pixelFormat);
|
||||
|
|
|
@ -119,8 +119,8 @@ bool StreamKeyValueParser::parseRole(StreamRole *role,
|
|||
} else if (name == "still") {
|
||||
*role = StreamRole::StillCapture;
|
||||
return true;
|
||||
} else if (name == "stillraw") {
|
||||
*role = StreamRole::StillCaptureRaw;
|
||||
} else if (name == "raw") {
|
||||
*role = StreamRole::Raw;
|
||||
return true;
|
||||
}
|
||||
|
||||
|
|
|
@ -348,7 +348,7 @@ CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,
|
|||
|
||||
break;
|
||||
|
||||
case StreamRole::StillCaptureRaw: {
|
||||
case StreamRole::Raw: {
|
||||
StreamConfiguration cio2Config =
|
||||
data->cio2_.generateConfiguration(sensorResolution);
|
||||
pixelFormat = cio2Config.pixelFormat;
|
||||
|
|
|
@ -461,7 +461,7 @@ CameraConfiguration *PipelineHandlerRPi::generateConfiguration(Camera *camera,
|
|||
unsigned int outCount = 0;
|
||||
for (const StreamRole role : roles) {
|
||||
switch (role) {
|
||||
case StreamRole::StillCaptureRaw:
|
||||
case StreamRole::Raw:
|
||||
size = data->sensor_->resolution();
|
||||
fmts = data->unicam_[Unicam::Image].dev()->formats();
|
||||
sensorFormat = findBestMode(fmts, size);
|
||||
|
|
|
@ -380,12 +380,11 @@ std::string StreamConfiguration::toString() const
|
|||
* are specified by applications and passed to cameras, that then select the
|
||||
* most appropriate streams and their default configurations.
|
||||
*
|
||||
* \var Raw
|
||||
* The stream is intended to capture raw frames from the sensor.
|
||||
* \var StillCapture
|
||||
* The stream is intended to capture high-resolution, high-quality still images
|
||||
* with low frame rate. The captured frames may be exposed with flash.
|
||||
* \var StillCaptureRaw
|
||||
* The stream is intended to capture high-resolution, raw still images with low
|
||||
* frame rate.
|
||||
* \var VideoRecording
|
||||
* The stream is intended to capture video for the purpose of recording or
|
||||
* streaming. The video stream may produce a high frame rate and may be
|
||||
|
|
|
@ -380,7 +380,7 @@ int MainWindow::startCapture()
|
|||
break;
|
||||
case 2:
|
||||
if (roles[0] != StreamRole::Viewfinder ||
|
||||
roles[1] != StreamRole::StillCaptureRaw) {
|
||||
roles[1] != StreamRole::Raw) {
|
||||
qWarning() << "Only viewfinder + raw supported for dual streams";
|
||||
return -EINVAL;
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue