Mirror/libcamera
1
0
Fork 0
mirror of https://git.libcamera.org/libcamera/libcamera.git synced 2025-07-25 17:45:06 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

apps: cam: kms_sink: Drop unique_ptr<> from DRM::AtomicRequest

Browse source 
There is no need to wrap DRM::AtomicRequest in std::unique_ptr<>
in KMSSink::start(). Remove it so that the syntax becomes similar to
what we have in KMSSink::stop().

No functional changes intended.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Umang Jain 2023-04-24 00:15:49 +05:30
parent 683c6da83f
commit e191001939
1 changed files with 5 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/apps/cam/kms_sink.cpp
View file

@ -303,24 +303,22 @@ int KMSSink::configurePipeline(const libcamera::PixelFormat &format)
int KMSSink::start() int KMSSink::start()
{ {
std::unique_ptr<DRM::AtomicRequest> request;
int ret = FrameSink::start(); int ret = FrameSink::start();
if (ret < 0) if (ret < 0)
return ret; return ret;
/* Disable all CRTCs and planes to start from a known valid state. */ /* Disable all CRTCs and planes to start from a known valid state. */
request = std::make_unique<DRM::AtomicRequest>(&dev_); DRM::AtomicRequest request(&dev_);
for (const DRM::Crtc &crtc : dev_.crtcs()) for (const DRM::Crtc &crtc : dev_.crtcs())
request->addProperty(&crtc, "ACTIVE", 0); request.addProperty(&crtc, "ACTIVE", 0);
for (const DRM::Plane &plane : dev_.planes()) { for (const DRM::Plane &plane : dev_.planes()) {
request->addProperty(&plane, "CRTC_ID", 0); request.addProperty(&plane, "CRTC_ID", 0);
request->addProperty(&plane, "FB_ID", 0); request.addProperty(&plane, "FB_ID", 0);
} }
ret = request->commit(DRM::AtomicRequest::FlagAllowModeset); ret = request.commit(DRM::AtomicRequest::FlagAllowModeset);
if (ret < 0) { if (ret < 0) {
std::cerr std::cerr
<< "Failed to disable CRTCs and planes: " << "Failed to disable CRTCs and planes: "