Mirror/libcamera
1
0
Fork 0
mirror of https://git.libcamera.org/libcamera/libcamera.git synced 2025-07-17 01:15:06 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

libcamera: pipeline: raspberrypi: Always save sensor params on IPA_RESULT_SENSOR_PARAMS

Browse source 
Fixup logic when handling IPA_RESULT_SENSOR_PARAMS where we must always
overwrite the parameters if provided by IPA. In the current codebase,
this only happens once on startup, so there is no effective functional
difference. But this change allows the option for the IPA to request new
sensor parameters per-mode if required.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Naushir Patuck 2021-02-01 12:56:33 +00:00 • committed by Laurent Pinchart
parent a08b216ac4
commit e81f9046ca
1 changed files with 7 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
View file

@ -1224,7 +1224,6 @@ int RPiCameraData::configureIPA(const CameraConfiguration *config)
* Setup our delayed control writer with the sensor default
* gain and exposure delays.
*/
if (!delayedCtrls_) {
std::unordered_map<uint32_t, unsigned int> delays = {
{ V4L2_CID_ANALOGUE_GAIN, result.data[resultIdx++] },
{ V4L2_CID_EXPOSURE, result.data[resultIdx++] },
@ -1235,7 +1234,6 @@ int RPiCameraData::configureIPA(const CameraConfiguration *config)
sensorMetadata_ = result.data[resultIdx++];
}
}
if (result.operation & RPi::IPA_RESULT_SENSOR_CTRLS) {
ControlList &ctrls = result.controls[0];