Mirror/libcamera
1
0
Fork 0
mirror of https://git.libcamera.org/libcamera/libcamera.git synced 2025-07-24 17:15:07 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

cam: sdl: Use uint32_t in place of SDL_PixelFormatEnum

Browse source 
The SDL_PixelFormatEnum type has been introduced in libsdl by
1a4c0d4e17e6 ("Fixed bug 4377 - SDL_PIXELFORMAT enum is anonymous, which
prevents its use in a templated function") which is only available after
release 2.0.10 of the library.

Debian 10 ships libsdl at version 2.0.9 and building cam with sdl
support there fails with error:
./src/cam/sdl_texture.h:27:8: error: ‘SDL_PixelFormatEnum’ does not name
a type; did you mean ‘SDL_PixelFormat’?

Fix that by using the base type uint32_t in place of
SDL_PixelFormatEnum.

Reported-by: https://buildbot.libcamera.org/#/builders/6/builds/355
Fixes: 11554a259f ("cam: sdl_sink: Add SDL sink with initial YUYV support")
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Eric Curtin <ecurtin@redhat.com>
This commit is contained in:
Jacopo Mondi 2022-07-14 20:14:26 +02:00
parent a5877e0307
commit e9b6b36282
2 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/cam/sdl_texture.cpp
View file

@ -9,7 +9,7 @@
#include <iostream>
SDLTexture::SDLTexture(const SDL_Rect &rect, SDL_PixelFormatEnum pixelFormat,
SDLTexture::SDLTexture(const SDL_Rect &rect, uint32_t pixelFormat,
const int pitch)
: ptr_(nullptr), rect_(rect), pixelFormat_(pixelFormat), pitch_(pitch)
{

5
src/cam/sdl_texture.h
View file

@ -14,8 +14,7 @@
class SDLTexture
{
public:
SDLTexture(const SDL_Rect &rect, SDL_PixelFormatEnum pixelFormat,
const int pitch);
SDLTexture(const SDL_Rect &rect, uint32_t pixelFormat, const int pitch);
virtual ~SDLTexture();
int create(SDL_Renderer *renderer);
virtual void update(const libcamera::Span<uint8_t> &data) = 0;
@ -24,6 +23,6 @@ public:
protected:
SDL_Texture *ptr_;
const SDL_Rect rect_;
const SDL_PixelFormatEnum pixelFormat_;
const uint32_t pixelFormat_;
const int pitch_;
};