Mirror/libcamera
1
0
Fork 0
mirror of https://git.libcamera.org/libcamera/libcamera.git synced 2025-07-16 00:45:07 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

ipa: raspberrypi: Set default values for member variables of MdParser

Browse source 
Set some sensible default values for member variables of the MdParser
class.

Remove buffer_size_bytes_ along with some related asserts as this class
now uses libcamera::Span for buffer handling, and buffer_size_bytes_ is
unused.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: David Plowman <david.plowman@raspberrypi.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Naushir Patuck 2021-06-14 10:53:36 +01:00 • committed by Laurent Pinchart
parent 12fdfee68f
commit f1dbf97eed
3 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/ipa/raspberrypi/cam_helper_imx219.cpp
View file

@ -128,7 +128,6 @@ MdParser::Status MdParserImx219::Parse(libcamera::Span<const uint8_t> buffer)
* registers. * registers.
*/ */
assert(bits_per_pixel_); assert(bits_per_pixel_);
assert(num_lines_ || buffer_size_bytes_);
/* Need to be ordered */ /* Need to be ordered */
uint32_t regs[3] = { GAIN_REG, EXPHI_REG, EXPLO_REG }; uint32_t regs[3] = { GAIN_REG, EXPHI_REG, EXPLO_REG };
reg_offsets_[0] = reg_offsets_[1] = reg_offsets_[2] = -1; reg_offsets_[0] = reg_offsets_[1] = reg_offsets_[2] = -1;

1
src/ipa/raspberrypi/cam_helper_imx477.cpp
View file

@ -117,7 +117,6 @@ MdParser::Status MdParserImx477::Parse(libcamera::Span<const uint8_t> buffer)
* registers. * registers.
*/ */
assert(bits_per_pixel_); assert(bits_per_pixel_);
assert(num_lines_ || buffer_size_bytes_);
/* Need to be ordered */ /* Need to be ordered */
uint32_t regs[4] = { uint32_t regs[4] = {
EXPHI_REG, EXPHI_REG,

4
src/ipa/raspberrypi/md_parser.hpp
View file

@ -71,7 +71,8 @@ public:
ERROR = 2 ERROR = 2
}; };
MdParser() : reset_(true) MdParser()
: reset_(true), bits_per_pixel_(0), num_lines_(0), line_length_bytes_(0)
{ {
} }
@ -106,7 +107,6 @@ protected:
int bits_per_pixel_; int bits_per_pixel_;
unsigned int num_lines_; unsigned int num_lines_;
unsigned int line_length_bytes_; unsigned int line_length_bytes_;
unsigned int buffer_size_bytes_;
}; };
/* /*