Mirror/libcamera
1
0
Fork 0
mirror of https://git.libcamera.org/libcamera/libcamera.git synced 2025-07-23 16:45:07 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

ipa: raspberrypi: Remove initialized_ field from CamHelper

Browse source 
Given that the single user of the CamHelper is the Raspberry Pi IPA, the
initialized_ field check is unnecessary. Remove the check and the field.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Naushir Patuck 2022-10-06 14:17:38 +01:00 • committed by Laurent Pinchart
parent f9c490ab25
commit f694da76be
2 changed files with 1 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/ipa/raspberrypi/cam_helper.cpp
View file

@ -7,7 +7,6 @@
#include <linux/videodev2.h>
#include <assert.h>
#include <map>
#include <string.h>
@ -41,8 +40,7 @@ CamHelper *CamHelper::create(std::string const &camName)
}
CamHelper::CamHelper(std::unique_ptr<MdParser> parser, unsigned int frameIntegrationDiff)
: parser_(std::move(parser)), initialized_(false),
frameIntegrationDiff_(frameIntegrationDiff)
: parser_(std::move(parser)), frameIntegrationDiff_(frameIntegrationDiff)
{
}
@ -63,13 +61,11 @@ void CamHelper::process([[maybe_unused]] StatisticsPtr &stats,
uint32_t CamHelper::exposureLines(const Duration exposure, const Duration lineLength) const
{
assert(initialized_);
return exposure / lineLength;
}
Duration CamHelper::exposure(uint32_t exposureLines, const Duration lineLength) const
{
assert(initialized_);
return exposureLines * lineLength;
}
@ -80,8 +76,6 @@ uint32_t CamHelper::getVBlanking(Duration &exposure,
uint32_t frameLengthMin, frameLengthMax, vblank;
uint32_t exposureLines = CamHelper::exposureLines(exposure, mode_.minLineLength);
assert(initialized_);
/*
* minFrameDuration and maxFrameDuration are clamped by the caller
* based on the limits for the active sensor mode.
@ -110,7 +104,6 @@ void CamHelper::setCameraMode(const CameraMode &mode)
parser_->setBitsPerPixel(mode.bitdepth);
parser_->setLineLengthBytes(0); /* We use SetBufferSize. */
}
initialized_ = true;
}
void CamHelper::getDelays(int &exposureDelay, int &gainDelay,

1
src/ipa/raspberrypi/cam_helper.h
View file

@ -106,7 +106,6 @@ protected:
CameraMode mode_;
private:
bool initialized_;
/*
* Smallest difference between the frame length and integration time,
* in units of lines.