test: Extract CameraTest class out of camera tests to libtest

Many tests other than the camera/ tests use a camera. To increase code
sharing, move the base CameraTest class to the test library. The class
becomes a helper that doesn't inherit from Test anymore (to avoid
diamond inheritance issues when more such helpers will exist).

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
This commit is contained in:
Laurent Pinchart 2019-10-27 19:20:39 +02:00
parent 6b3308ba1b
commit fac471e812
10 changed files with 77 additions and 76 deletions

View file

@ -0,0 +1,52 @@
/* SPDX-License-Identifier: GPL-2.0-or-later */
/*
* Copyright (C) 2019, Google Inc.
*
* libcamera Camera API tests
*/
#include <iostream>
#include "camera_test.h"
#include "test.h"
using namespace libcamera;
using namespace std;
CameraTest::CameraTest(const char *name)
{
cm_ = new CameraManager();
if (cm_->start()) {
cerr << "Failed to start camera manager" << endl;
status_ = TestFail;
return;
}
camera_ = cm_->get(name);
if (!camera_) {
cerr << "Can not find '" << name << "' camera" << endl;
status_ = TestSkip;
return;
}
/* Sanity check that the camera has streams. */
if (camera_->streams().empty()) {
cerr << "Camera has no stream" << endl;
status_ = TestFail;
return;
}
status_ = TestPass;
}
CameraTest::~CameraTest()
{
if (camera_) {
camera_->release();
camera_.reset();
}
cm_->stop();
delete cm_;
}

View file

@ -0,0 +1,26 @@
/* SPDX-License-Identifier: GPL-2.0-or-later */
/*
* Copyright (C) 2019, Google Inc.
*
* camera_test.h - libcamera camera test base class
*/
#ifndef __LIBCAMERA_CAMERA_TEST_H__
#define __LIBCAMERA_CAMERA_TEST_H__
#include <libcamera/libcamera.h>
using namespace libcamera;
class CameraTest
{
public:
CameraTest(const char *name);
~CameraTest();
protected:
CameraManager *cm_;
std::shared_ptr<Camera> camera_;
int status_;
};
#endif /* __LIBCAMERA_CAMERA_TEST_H__ */

View file

@ -1,4 +1,5 @@
libtest_sources = files([
'camera_test.cpp',
'test.cpp',
])