mirror of
https://git.libcamera.org/libcamera/libcamera.git
synced 2025-07-24 09:05:06 +03:00
64bcbd0e2c
Currently, we use Camera3RequestDescriptor::Status to determine: - When the descriptor has been completely processed by HAL - Whether any errors were encountered, during its processing Both of these are essential to know whether the descriptor is eligible to call process_capture_results() through sendCaptureResults(). When a status(Success/Error) is set on the descriptor, it is ready to be sent back via sendCaptureResults(). However, this might lead to undesired results especially when sendCaptureResults() runs in a different thread (for e.g. stream's post-processor async completion slot). This patch decouples the descriptor status (Success/Error) from the descriptor's completion status (pending or complete). The advantage of this is we can set the completion status when the descriptor has been processed fully by the layer and we can set the error status on the descriptor wherever an error is encountered, throughout the lifetime of the descriptor in the HAL layer. While at it, introduce a wrapper completeDescriptor() around sendCaptureResults(). completeDescriptor() as the name suggests will mark the descriptor as complete, so it is ready to be sent back. The locking mechanism is moved from sendCaptureResults() to this wrapper since the intention is to use completeDescriptor() in place of existing sendCaptureResults() calls. Also make sure the sequence of abortRequest() call happens in the same order at all places i.e. after its added to the descriptors_ queue. Fix one of the abortRequest() call accordingly. Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Hirokazu Honda <hiroh@chromium.org> |
||
|---|---|---|
| .. | ||
| cros | ||
| data | ||
| jpeg | ||
| metadata | ||
| mm | ||
| yuv | ||
| camera3_hal.cpp | ||
| camera_buffer.h | ||
| camera_capabilities.cpp | ||
| camera_capabilities.h | ||
| camera_device.cpp | ||
| camera_device.h | ||
| camera_hal_config.cpp | ||
| camera_hal_config.h | ||
| camera_hal_manager.cpp | ||
| camera_hal_manager.h | ||
| camera_metadata.cpp | ||
| camera_metadata.h | ||
| camera_ops.cpp | ||
| camera_ops.h | ||
| camera_request.cpp | ||
| camera_request.h | ||
| camera_stream.cpp | ||
| camera_stream.h | ||
| camera_worker.cpp | ||
| camera_worker.h | ||
| meson.build | ||
| post_processor.h | ||