mirror of
https://git.libcamera.org/libcamera/libcamera.git
synced 2025-07-13 15:29:45 +03:00
The libcamera internal headers are located in src/libcamera/include/. The directory is added to the compiler headers search path with a meson include_directories() directive, and internal headers are included with (e.g. for the internal semaphore.h header) #include "semaphore.h" All was well, until libcxx decided to implement the C++20 synchronization library. The __threading_support header gained a #include <semaphore.h> to include the pthread's semaphore support. As include_directories() adds src/libcamera/include/ to the compiler search path with -I, the internal semaphore.h is included instead of the pthread version. Needless to say, the compiler isn't happy. Three options have been considered to fix this issue: - Use -iquote instead of -I. The -iquote option instructs gcc to only consider the header search path for headers included with the "" version. Meson unfortunately doesn't support this option. - Rename the internal semaphore.h header. This was deemed to be the beginning of a long whack-a-mole game, where namespace clashes with system libraries would appear over time (possibly dependent on particular system configurations) and would need to be constantly fixed. - Move the internal headers to another directory to create a unique namespace through path components. This causes lots of churn in all the existing source files through the all project. The first option would be best, but isn't available to us due to missing support in meson. Even if -iquote support was added, we would need to fix the problem before a new version of meson containing the required support would be released. The third option is thus the only practical solution available. Bite the bullet, and do it, moving headers to include/libcamera/internal/. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Acked-by: Jacopo Mondi <jacopo@jmondi.org>
107 lines
1.8 KiB
C++
107 lines
1.8 KiB
C++
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* Copyright (C) 2019, Google Inc.
|
|
*
|
|
* timer-thread.cpp - Threaded timer test
|
|
*/
|
|
|
|
#include <chrono>
|
|
#include <iostream>
|
|
|
|
#include <libcamera/event_dispatcher.h>
|
|
#include <libcamera/timer.h>
|
|
|
|
#include "libcamera/internal/thread.h"
|
|
|
|
#include "test.h"
|
|
|
|
using namespace std;
|
|
using namespace libcamera;
|
|
|
|
class TimeoutHandler : public Object
|
|
{
|
|
public:
|
|
TimeoutHandler()
|
|
: timer_(this), timeout_(false)
|
|
{
|
|
timer_.timeout.connect(this, &TimeoutHandler::timeoutHandler);
|
|
timer_.start(100);
|
|
}
|
|
|
|
void restart()
|
|
{
|
|
timeout_ = false;
|
|
timer_.start(100);
|
|
}
|
|
|
|
bool timeout() const
|
|
{
|
|
return timeout_;
|
|
}
|
|
|
|
private:
|
|
void timeoutHandler(Timer *timer)
|
|
{
|
|
timeout_ = true;
|
|
}
|
|
|
|
Timer timer_;
|
|
bool timeout_;
|
|
};
|
|
|
|
class TimerThreadTest : public Test
|
|
{
|
|
protected:
|
|
int init()
|
|
{
|
|
thread_.start();
|
|
timeout_.moveToThread(&thread_);
|
|
|
|
return TestPass;
|
|
}
|
|
|
|
int run()
|
|
{
|
|
/*
|
|
* Test that the timer expires and emits the timeout signal in
|
|
* the thread it belongs to.
|
|
*/
|
|
this_thread::sleep_for(chrono::milliseconds(200));
|
|
|
|
if (!timeout_.timeout()) {
|
|
cout << "Timer expiration test failed" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
/*
|
|
* Test that starting the timer from another thread fails. We
|
|
* need to interrupt the event dispatcher to make sure we don't
|
|
* succeed simply because the event dispatcher hasn't noticed
|
|
* the timer restart.
|
|
*/
|
|
timeout_.restart();
|
|
thread_.eventDispatcher()->interrupt();
|
|
|
|
this_thread::sleep_for(chrono::milliseconds(200));
|
|
|
|
if (timeout_.timeout()) {
|
|
cout << "Timer restart test failed" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
return TestPass;
|
|
}
|
|
|
|
void cleanup()
|
|
{
|
|
/* Must stop thread before destroying timeout. */
|
|
thread_.exit(0);
|
|
thread_.wait();
|
|
}
|
|
|
|
private:
|
|
TimeoutHandler timeout_;
|
|
Thread thread_;
|
|
};
|
|
|
|
TEST_REGISTER(TimerThreadTest)
|