libcamera/test
Paul Elder 31078711d6 ipa: Use FileDescriptor instead of int in layers above IPC payload
Regarding (de)serialization in isolated IPA calls, we have four layers:
- struct
- byte vector + fd vector
- IPCMessage
- IPC payload

The proxy handles the upper three layers (with help from the
IPADataSerializer), and passes an IPCMessage to the IPC mechanism
(implemented as an IPCPipe), which sends an IPC payload to its worker
counterpart.

When a FileDescriptor is involved, previously it was only a
FileDescriptor in the first layer; in the lower three it was an int. To
reduce the risk of potential fd leaks in the future, keep the
FileDescriptor as-is throughout the upper three layers. Only the IPC
mechanism will deal with ints, if it so wishes, when it does the actual
IPC. IPCPipeUnixSocket does deal with ints for sending fds, so the
conversion between IPCMessage and IPCUnixSocket::Payload converts
between FileDescriptor and int.

Additionally, change the data portion of the serialized form of
FileDescriptor to a 32-bit unsigned integer, for alightnment purposes
and in preparation for conversion to an index into the fd array.

Also update the deserializer of FrameBuffer::Plane accordingly.

Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
Tested-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
2021-08-19 16:54:02 +09:00
..
camera test: camera: Camera reconfiguration and fd-leak test 2021-08-19 13:16:15 +05:30
controls controls: Add boolean constructors for ControlInfo 2021-08-02 18:07:16 +09:00
gstreamer test: gstreamer: Add test for gstreamer single stream 2021-08-14 22:58:46 +03:00
ipa libcamera/base: Validate internal headers as private 2021-06-25 16:11:11 +01:00
ipc libcamera/base: Validate internal headers as private 2021-06-25 16:11:11 +01:00
libtest libtest: camera_test: Plumb constructor to set LIBCAMERA_IPA_FORCE_ISOLATION 2021-08-19 12:54:03 +05:30
log libcamera/base: Validate internal headers as private 2021-06-25 16:11:11 +01:00
media_device libcamera: Rename 'method' to 'function' 2021-08-09 15:40:32 +03:00
pipeline libcamera/base: Validate internal headers as private 2021-06-25 16:11:11 +01:00
process libcamera/base: Validate internal headers as private 2021-06-25 16:11:11 +01:00
serialization ipa: Use FileDescriptor instead of int in layers above IPC payload 2021-08-19 16:54:02 +09:00
stream libcamera: rename public libcamera dependency 2021-06-25 16:11:11 +01:00
v4l2_compat tests: v4l2_compat: Fix v4l2-compliance and v4l2-ctl version parsing 2020-07-17 18:50:10 +09:00
v4l2_subdevice libcamera: buffer: Rename buffer.h to framebuffer.h 2021-07-11 17:42:02 +03:00
v4l2_videodevice libcamera: buffer: Rename buffer.h to framebuffer.h 2021-07-11 17:42:02 +03:00
bayer-format.cpp test: bayer-format: Rectify internal header's #include path 2021-05-05 10:32:33 +02:00
byte-stream-buffer.cpp test: byte-stream-buffer: Initialize data array 2021-05-26 10:24:15 +02:00
camera-sensor.cpp libcamera/base: Move utils to the base library 2021-06-25 16:11:02 +01:00
delayed_controls.cpp test: delayed_controls: Rename delayed_contols.cpp to delayed_controls.cpp 2021-03-12 14:20:51 +00:00
event-dispatcher.cpp libcamera/base: Move extended base functionality 2021-06-25 16:11:08 +01:00
event-thread.cpp libcamera/base: Move event_notifier to base 2021-06-25 16:11:10 +01:00
event.cpp libcamera/base: Move event_notifier to base 2021-06-25 16:11:10 +01:00
file-descriptor.cpp libcamera/base: Move utils to the base library 2021-06-25 16:11:02 +01:00
file.cpp libcamera: file: Turn MapFlag and OpenModeFlag into enum class 2021-08-03 10:55:33 +03:00
flags.cpp test: Add tests for the Flags class 2021-08-03 10:55:21 +03:00
geometry.cpp test: geometry: Add unit tests for new geometry helper functions 2020-10-27 14:06:51 +02:00
hotplug-cameras.cpp libcamera/base: Move File to base library 2021-06-25 16:11:10 +01:00
mapped-buffer.cpp libcamera: MappedFrameBuffer: Use typed Flags<MapModes> 2021-08-10 10:57:04 +01:00
meson.build test: gstreamer: Add test for gstreamer single stream 2021-08-14 22:58:46 +03:00
message.cpp test: message: Test recursive Thread::dispatchMessages() calls 2021-07-11 17:41:59 +03:00
object-delete.cpp libcamera/base: Move extended base functionality 2021-06-25 16:11:08 +01:00
object-invoke.cpp libcamera/base: Move extended base functionality 2021-06-25 16:11:08 +01:00
object.cpp libcamera/base: Move extended base functionality 2021-06-25 16:11:08 +01:00
pixel-format.cpp libcamera/base: Move utils to the base library 2021-06-25 16:11:02 +01:00
public-api.cpp test: Ensure LIBCAMERA_BASE_PRIVATE isn't public 2021-06-25 16:11:11 +01:00
signal-threads.cpp libcamera/base: Move extended base functionality 2021-06-25 16:11:08 +01:00
signal.cpp libcamera: Rename 'method' to 'function' 2021-08-09 15:40:32 +03:00
span.cpp libcamera/base: Move span to base library 2021-06-25 16:11:11 +01:00
threads.cpp libcamera/base: Move extended base functionality 2021-06-25 16:11:08 +01:00
timer-thread.cpp libcamera/base: Move extended base functionality 2021-06-25 16:11:08 +01:00
timer.cpp libcamera/base: Move extended base functionality 2021-06-25 16:11:08 +01:00
utils.cpp libcamera/base: Move span to base library 2021-06-25 16:11:11 +01:00