mirror of
https://git.libcamera.org/libcamera/libcamera.git
synced 2025-07-13 07:19:45 +03:00
The current test verifies that after adding a new control to a list
already populated with one control the new one is present.
However the test wrongly tests for its presence twice instead of
making sure the existing control is still there.
Fix this by checking for the presence of both controls after the
update, and fix the error message accordingly.
Fixes: a8c40942b9
("libcamera: controls: Improve the API towards applications")
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
157 lines
3.5 KiB
C++
157 lines
3.5 KiB
C++
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* Copyright (C) 2019, Google Inc.
|
|
*
|
|
* control_list.cpp - ControlList tests
|
|
*/
|
|
|
|
#include <iostream>
|
|
|
|
#include <libcamera/camera.h>
|
|
#include <libcamera/camera_manager.h>
|
|
#include <libcamera/control_ids.h>
|
|
#include <libcamera/controls.h>
|
|
|
|
#include "libcamera/internal/camera_controls.h"
|
|
|
|
#include "camera_test.h"
|
|
#include "test.h"
|
|
|
|
using namespace std;
|
|
using namespace libcamera;
|
|
|
|
class ControlListTest : public CameraTest, public Test
|
|
{
|
|
public:
|
|
ControlListTest()
|
|
: CameraTest("platform/vimc.0 Sensor B")
|
|
{
|
|
}
|
|
|
|
protected:
|
|
int init() override
|
|
{
|
|
return status_;
|
|
}
|
|
|
|
int run() override
|
|
{
|
|
CameraControlValidator validator(camera_.get());
|
|
ControlList list(controls::controls, &validator);
|
|
|
|
/* Test that the list is initially empty. */
|
|
if (!list.empty()) {
|
|
cout << "List should to be empty" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
if (list.size() != 0) {
|
|
cout << "List should contain zero items" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
if (list.contains(controls::Brightness)) {
|
|
cout << "List should not contain Brightness control" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
unsigned int count = 0;
|
|
for (auto iter = list.begin(); iter != list.end(); ++iter)
|
|
count++;
|
|
|
|
if (count != 0) {
|
|
cout << "List iteration should not produce any item" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
/*
|
|
* Set a control, and verify that the list now contains it, and
|
|
* nothing else.
|
|
*/
|
|
list.set(controls::Brightness, -0.5f);
|
|
|
|
if (list.empty()) {
|
|
cout << "List should not be empty" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
if (list.size() != 1) {
|
|
cout << "List should contain one item" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
if (!list.contains(controls::Brightness)) {
|
|
cout << "List should contain Brightness control" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
count = 0;
|
|
for (auto iter = list.begin(); iter != list.end(); ++iter)
|
|
count++;
|
|
|
|
if (count != 1) {
|
|
cout << "List iteration should produce one item" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
if (list.get(controls::Brightness) != -0.5f) {
|
|
cout << "Incorrest Brightness control value" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
if (list.contains(controls::Contrast)) {
|
|
cout << "List should not contain Contract control" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
/* Update the first control and set a second one. */
|
|
list.set(controls::Brightness, 0.0f);
|
|
list.set(controls::Contrast, 1.5f);
|
|
|
|
if (!list.contains(controls::Brightness) ||
|
|
!list.contains(controls::Contrast)) {
|
|
cout << "List should contain Brightness and Contrast controls"
|
|
<< endl;
|
|
return TestFail;
|
|
}
|
|
|
|
if (list.get(controls::Brightness) != 0.0f ||
|
|
list.get(controls::Contrast) != 1.5f) {
|
|
cout << "Failed to retrieve control value" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
/*
|
|
* Update both controls and verify that the container doesn't
|
|
* grow.
|
|
*/
|
|
list.set(controls::Brightness, 0.5f);
|
|
list.set(controls::Contrast, 1.1f);
|
|
|
|
if (list.get(controls::Brightness) != 0.5f ||
|
|
list.get(controls::Contrast) != 1.1f) {
|
|
cout << "Failed to update control value" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
if (list.size() != 2) {
|
|
cout << "List should contain two elements" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
/*
|
|
* Attempt to set an invalid control and verify that the
|
|
* operation failed.
|
|
*/
|
|
list.set(controls::AwbEnable, true);
|
|
|
|
if (list.contains(controls::AwbEnable)) {
|
|
cout << "List shouldn't contain AwbEnable control" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
return TestPass;
|
|
}
|
|
};
|
|
|
|
TEST_REGISTER(ControlListTest)
|