Commit 45c14ef4d5 ("libusbgx: fix build with glibc-2.28 since
<sys/sysmacros.h> is no more included by <sys/types.h>")
fixed this issue for the (default) --with-libconfig configuration,
but building --without-libconfig still throws a linker error
because makedev was assumed to be an external symbol in
usbg_common.c.
Include <sys/sysmacros.h> there to address this.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
This is the USB Audio Class 2 function that creates an ALSA audio device
exposed as a USB gadget function.
Signed-off-by: John Keeping <john@metanate.com>
[Set import/export callbacks to correct values,
adjust convention of set_attr(),
fix union cast in c++]
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com
USB function should have both type and instance name.
Mistakenly it was possible to create function with empty instance
name. This may lead to situations like FunctionFS device name
identified by "" or some misleading debug messages from TCM like:
tcm: Activating
Additionaly trying to execute usbg_init() after creating such
a function fails with -3 USBG_ERROR_INVALID_PARAM because it checks
if instance name is not empty.
To avoid this let's add a check in usbg_create_function() that
instance name should have at least one character.
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Since we added support for OS descriptors we allowed user
to create a link in gadget's os_desc directory to choose
one of available configurations. This link prevents config
from being removed. This makes our rm funcitons stop working
with the recursive option. To fix this, let's make them
OS desc aware and remove this link before trying to remove
configuration if recurse option is set.
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
OS Descriptors require an association to a single configuration. This
allows to use a specific configuration for hosts supporting OS
Descriptors.
Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
[Allow to also remove os desc binding]
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
This adds support for OS Descriptors available on function level,
called "Feature Descriptors".
Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
[Use a little bit different convention]
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
This adds support for OS Descriptors available on function level,
called "Feature Descriptors".
Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
[Fix mem leak in error path, allow multiple ifaces per funciton]
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
This adds interface name required for "Feature Descriptors". If
specified, we can assume that a Feature Descriptor with the
interface name of the specified string is understood by the
kernel (e.g. interface.rndis).
Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
[Allow multiple os_desc ifaces per funciton]
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Add configuration support for OS Descriptors.
Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
[Move import to the right place, don't strdup() during import]
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
This adds OS Descriptors support on Gadget level. It allows to
enable OS Descriptors support as well as to define the OS String
proper.
Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
[Remove unused variable]
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
The helper usbg_write_string() adds one to the length of the provided
string. This leads to usbg_write_buf() writting also a null terminator
to the kernel which is not necessary/wrong. Provide usbg_write_buf
the real string length.
Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
[Add missing () to function names in commit msg]
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
According to man fclose:
"The fclose() function may also fail and set errno for any of the
errors specified for the routines close(2), write(2) or fflush(3)."
So if libc decides to cache our write till closing fd we may
miss the error if we ignore value returned from fclose().
This fixes issue #12 (github).
Reported-by: Noralf Trønnes <noralf@tronnes.org>
Suggested-by: Noralf Trønnes <noralf@tronnes.org>
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
We have two configure options related to libconfig:
1) --disable-gadget-schemes
2) --without-libconfig
Option #1 means that libusbgx itself should be compiled without gadget
schemes support. Option #2 means that everything what requires
libconfig should be turned off. So option #2 is wider than #1 as
libconfig us used also in our testing program.
To fix this meaning let's use HAS_GADGET_SCHEMES inside library source
code to determine if we should use libconfig or not and HAS_LIBCONFIG
inside our tests source code.
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
After refactorization we lost ability to build libusbgx
without libconfig. Let's restore this.
Basic concept is that the whole code related to libconfig usage
should be under #ifdef or compiled only if libconfig support
is enabled.
To prevent future problems of that kind, let's create a header
which is included when compiling without libconfig. Inside it we
like:
struct s {
.import = usbg_get_config_node_int,
.export = usbg_set_config_node_int,
};
are still valid, but all tries to call this functions directly end up
in compilation error. This helps us identify all pieces of code
which should be placed under suitable #ifdef.
Based on initial pull request "Compilation fixes. #4" by:
Bent Bisballe Nyeng (github: aasimon) <deva@aasimon.org>
Reported-by: Bent Bisballe Nyeng (github: aasimon) <deva@aasimon.org>
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
HID function has been ported to ConfigFS interface quite long
time ago so let's add support for it also in libusbgx.
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Add a helper to export int attributes in hex format.
Now each function may decide which format should be used
(decimal or hex).
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
As some of kernel functions expose details about device node
which is assigned to this instance in form:
<major>:<minor>
Let's add a convenient helper which will read those values
form file and convert them to dev_t.
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Reading binary data using fgets() may not be a good idea due
to \0 byte in the middle of data. Let's fix this by using fread()
instead of fgets().
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Using fputs() for writing binary data is not a good idea as \0
byte can be in the middle of our data. Let's just use fwrite()
instead.
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Make use of usbg_get_gadget_strs_langs() and
usbg_get_config_strs_langs() in libconfig schemes instead of
direct listing content of directory using scandir().
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Add a function which allows to get the list of languages
in which config strings are currently available.
Thanks to this function now we may iterate through all strings
languages available in particular config and print their values.
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Add a function which allows to get the list of languages
in which gadget strings are currently available.
Thanks to this function now we may iterate through all strings
languages available in particular gadget and print their values
for each language.
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
This is a first step to get rid of static buffers from usbg_config_strs.
This function should be called to release memory allocated for
configuration string.
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Let's keep gadget strings in the same order as they appear
in USB device descriptor to avoid mistakes during structure
initialization.
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
str_ser, str_prd and str_mnf are a little bit weird names
so let's replace them with names defined by USB spec.
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Let's remove typedefs from public structures to clearly
indicate users which structures can be accessed and which
should be used only as handles.
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
snprintf is used multiple times in usb_common.c,
but it did not include stdio.h before.
Signed-off-by: Fabian Vogt <fvogt@suse.com>
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Instead of having _cpy_ and _len function for getting
each string value let's use *_s() which behave like snprintf()
family.
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
