From 55cb5dce877786a79bab1b5707ff77a95102bc40 Mon Sep 17 00:00:00 2001 From: Damjan Adamic Date: Sun, 3 Aug 2014 17:27:39 +0200 Subject: [PATCH 1/5] Re #1567: readEeprom(): * added PID to temporary file name * better error message * temporary file deletion --- companion/src/avroutputdialog.cpp | 4 ++-- companion/src/mainwindow.cpp | 14 ++++++++++---- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/companion/src/avroutputdialog.cpp b/companion/src/avroutputdialog.cpp index a5f3e630b..fd3862ee5 100644 --- a/companion/src/avroutputdialog.cpp +++ b/companion/src/avroutputdialog.cpp @@ -156,11 +156,11 @@ void avrOutputDialog::doCopy() dest.close(); } else { - QMessageBox::warning(this, tr("Error"),tr("Cannot write destination") + ": " + dest.errorString()); + QMessageBox::warning(this, tr("Error"),tr("Cannot write destination") + ": " + dest.fileName() + ", " + tr("reason") + ": " + dest.errorString()); } } else { - QMessageBox::warning(this, tr("Error"),tr("Cannot open source file") + ": " + source.errorString()); + QMessageBox::warning(this, tr("Error"),tr("Cannot open source file") + ": " + source.fileName() + ", " + tr("reason") + ": " + source.errorString()); } source.close(); diff --git a/companion/src/mainwindow.cpp b/companion/src/mainwindow.cpp index 2f1823583..d5341dc33 100644 --- a/companion/src/mainwindow.cpp +++ b/companion/src/mainwindow.cpp @@ -947,20 +947,23 @@ QString MainWindow::FindMassstoragePath(QString filename) void MainWindow::readEeprom() { QString tempDir = QDir::tempPath(); - QString tempFile; + QString tempFile = tempDir + QString("/temp-%1").arg(QCoreApplication::applicationPid());; EEPROMInterface *eepromInterface = GetEepromInterface(); if (IS_ARM(eepromInterface->getBoard())) - tempFile = tempDir + "/temp.bin"; + tempFile += ".bin"; else - tempFile = tempDir + "/temp.hex"; + tempFile += ".hex"; + + qDebug() << "MainWindow::readEeprom(): using temp file: " << tempFile; if (readEepromFromRadio(tempFile, tr("Read Models and Settings From Radio"))) { MdiChild *child = createMdiChild(); child->newFile(); child->loadFile(tempFile, false); child->show(); + unlink(tempFile.toAscii()); } } @@ -1042,7 +1045,10 @@ bool MainWindow::readEepromFromRadio(const QString filename, const QString messa QFile file(filename); if (file.exists()) { - file.remove(); + if (!file.remove()) { + QMessageBox::warning(this, tr("Error"), tr("Could not delete temporary file: %1").arg(filename)); + return false; + } } if (IS_ARM(GetCurrentFirmware()->getBoard())) { From c0e612531d3ae22f6a6f6d462f4222defe8faa97 Mon Sep 17 00:00:00 2001 From: Damjan Adamic Date: Sun, 3 Aug 2014 17:37:24 +0200 Subject: [PATCH 2/5] Re #1567: writeBackup(): added PID to temporary file name --- companion/src/mainwindow.cpp | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/companion/src/mainwindow.cpp b/companion/src/mainwindow.cpp index d5341dc33..a50a01152 100644 --- a/companion/src/mainwindow.cpp +++ b/companion/src/mainwindow.cpp @@ -1172,12 +1172,12 @@ void MainWindow::writeBackup() } int oldrev = getEpromVersion(fileName); QString tempDir = QDir::tempPath(); - QString tempFlash = tempDir + "/flash.bin"; + QString tempFlash = tempDir + QString("/flash-%1.bin").arg(QCoreApplication::applicationPid()); if (!readFirmwareFromRadio(tempFlash)) return; - QString restoreFile = tempDir + "/compat.bin"; + QString restoreFile = tempDir + QString("/compat.bin-%1.bin").arg(QCoreApplication::applicationPid()); if (!convertEEPROM(fileName, restoreFile, tempFlash)) { int ret = QMessageBox::question(this, "Error", tr("Cannot check Models and Settings compatibility! Continue anyway?") , QMessageBox::Yes | QMessageBox::No); @@ -1194,9 +1194,7 @@ void MainWindow::writeBackup() } fileName = restoreFile; } - QByteArray ba = tempFlash.toLatin1(); - char *name = ba.data(); - unlink(name); + unlink(tempFlash.toAscii()); } else { if (backupEnable) { From 4103adf75d2958f043ef1da55c237de53e3b29f0 Mon Sep 17 00:00:00 2001 From: Damjan Adamic Date: Sun, 3 Aug 2014 18:03:13 +0200 Subject: [PATCH 3/5] Re #1567: introduced unlink() function that takes QString parameter --- companion/src/burnconfigdialog.cpp | 2 +- companion/src/comparedialog.cpp | 8 ++------ companion/src/helpers.cpp | 7 +++++++ companion/src/helpers.h | 3 +++ companion/src/mainwindow.cpp | 6 +++--- companion/src/mdichild.cpp | 4 +--- companion/src/printdialog.cpp | 8 ++------ 7 files changed, 19 insertions(+), 19 deletions(-) diff --git a/companion/src/burnconfigdialog.cpp b/companion/src/burnconfigdialog.cpp index b4b865adf..2ccf4609a 100644 --- a/companion/src/burnconfigdialog.cpp +++ b/companion/src/burnconfigdialog.cpp @@ -376,7 +376,7 @@ void burnConfigDialog::restFuses(bool eeProtect) lfuses="lfuse:w:0x3F:m"; } file.close(); - unlink(tempFile.toAscii()); + unlink(tempFile); } else { lfuses="lfuse:w:0x3F:m"; diff --git a/companion/src/comparedialog.cpp b/companion/src/comparedialog.cpp index d6eb436ac..94197c382 100644 --- a/companion/src/comparedialog.cpp +++ b/companion/src/comparedialog.cpp @@ -156,12 +156,8 @@ void CompareDialog::dropEvent(QDropEvent *event) void CompareDialog::closeEvent(QCloseEvent *event) { - QByteArray ba = curvefile5.toLatin1(); - char *name = ba.data(); - unlink(name); - ba = curvefile9.toLatin1(); - name = ba.data(); - unlink(name); + unlink(curvefile5); + unlink(curvefile9); } CompareDialog::~CompareDialog() diff --git a/companion/src/helpers.cpp b/companion/src/helpers.cpp index 8263f8035..f726949db 100644 --- a/companion/src/helpers.cpp +++ b/companion/src/helpers.cpp @@ -964,3 +964,10 @@ QString index2version(int index) return QString(); } } + + +int unlink(const QString & fileName) +{ + QByteArray ba = fileName.toLatin1(); + return unlink(ba.constData()); +} diff --git a/companion/src/helpers.h b/companion/src/helpers.h index 9f735870a..5d33e1a0a 100644 --- a/companion/src/helpers.h +++ b/companion/src/helpers.h @@ -139,4 +139,7 @@ class QTimeS : public QTime int seconds() const { return hour()*3600 + minute()*60 + second(); }; }; + +int unlink(const QString & fileName); + #endif // HELPERS_H diff --git a/companion/src/mainwindow.cpp b/companion/src/mainwindow.cpp index a50a01152..d48be68bb 100644 --- a/companion/src/mainwindow.cpp +++ b/companion/src/mainwindow.cpp @@ -806,7 +806,7 @@ QStringList MainWindow::GetSambaArguments(const QString &tcl) QString tclFilename = QDir::tempPath() + "/temp.tcl"; if (QFile::exists(tclFilename)) { - unlink(tclFilename.toAscii()); + unlink(tclFilename); } QFile tclFile(tclFilename); if (!tclFile.open(QIODevice::WriteOnly | QIODevice::Text)) { @@ -963,7 +963,7 @@ void MainWindow::readEeprom() child->newFile(); child->loadFile(tempFile, false); child->show(); - unlink(tempFile.toAscii()); + unlink(tempFile); } } @@ -1194,7 +1194,7 @@ void MainWindow::writeBackup() } fileName = restoreFile; } - unlink(tempFlash.toAscii()); + unlink(tempFlash); } else { if (backupEnable) { diff --git a/companion/src/mdichild.cpp b/companion/src/mdichild.cpp index 03a7b5ddc..a62be58e0 100644 --- a/companion/src/mdichild.cpp +++ b/companion/src/mdichild.cpp @@ -571,9 +571,7 @@ void MdiChild::writeEeprom() // write to Tx } tempFile=restoreFile; } - QByteArray ba = tempFlash.toLatin1(); - char *name = ba.data(); - unlink(name); + unlink(tempFlash); } else { if (backupEnable) { diff --git a/companion/src/printdialog.cpp b/companion/src/printdialog.cpp index eee4816da..2e8d281b1 100644 --- a/companion/src/printdialog.cpp +++ b/companion/src/printdialog.cpp @@ -61,12 +61,8 @@ PrintDialog::PrintDialog(QWidget *parent, FirmwareInterface * firmware, GeneralS void PrintDialog::closeEvent(QCloseEvent *event) { if (printfilename.isEmpty()) { - QByteArray ba = curvefile5.toLatin1(); - char *name = ba.data(); - unlink(name); - ba = curvefile9.toLatin1(); - name = ba.data(); - unlink(name); + unlink(curvefile5); + unlink(curvefile9); } } From 741ef45f3e5630bacfcf52809517e52ebdfff1c3 Mon Sep 17 00:00:00 2001 From: Damjan Adamic Date: Sun, 3 Aug 2014 19:18:28 +0200 Subject: [PATCH 4/5] Re #1567: introduced generateProcessUniqueTempFileName() which is used everywhere we need temporary file renamed unlink() into qunlink() fixed missing deletion of curve pngs in print dialog --- companion/src/burnconfigdialog.cpp | 6 ++---- companion/src/burndialog.cpp | 8 +++----- companion/src/comparedialog.cpp | 4 ++-- companion/src/helpers.cpp | 17 ++++++++++++++++- companion/src/helpers.h | 4 +++- companion/src/logsdialog.cpp | 12 ++++++------ companion/src/mainwindow.cpp | 25 +++++++++++-------------- companion/src/mdichild.cpp | 9 ++++----- companion/src/printdialog.cpp | 19 ++++++++++--------- 9 files changed, 57 insertions(+), 47 deletions(-) diff --git a/companion/src/burnconfigdialog.cpp b/companion/src/burnconfigdialog.cpp index 2ccf4609a..3c52fbecc 100644 --- a/companion/src/burnconfigdialog.cpp +++ b/companion/src/burnconfigdialog.cpp @@ -354,10 +354,8 @@ void burnConfigDialog::restFuses(bool eeProtect) //use hfuse = 0x81 to prevent eeprom being erased with every flashing } else { - QString tempDir = QDir::tempPath(); - QString tempFile; QString lfuses; - tempFile = tempDir + "/ftemp.bin"; + QString tempFile = generateProcessUniqueTempFileName("ftemp.bin"); QStringList argread; argread << "-c" << avrProgrammer << "-p" << avrMCU << args <<"-U" << "lfuse:r:"+tempFile+":r" ; avrOutputDialog *ad = new avrOutputDialog(this, avrLoc, argread, "Reset Fuses",AVR_DIALOG_CLOSE_IF_SUCCESSFUL,FALSE); @@ -376,7 +374,7 @@ void burnConfigDialog::restFuses(bool eeProtect) lfuses="lfuse:w:0x3F:m"; } file.close(); - unlink(tempFile); + qunlink(tempFile); } else { lfuses="lfuse:w:0x3F:m"; diff --git a/companion/src/burndialog.cpp b/companion/src/burndialog.cpp index a64ee1a37..d0c166cfc 100644 --- a/companion/src/burndialog.cpp +++ b/companion/src/burndialog.cpp @@ -418,12 +418,11 @@ void burnDialog::on_BurnFlashButton_clicked() image = pixmap->toImage().scaled(ui->imageLabel->width(), ui->imageLabel->height()); } if (!image.isNull()) { - QString tempDir = QDir::tempPath(); QString tempFile; if (getFileType(fileName) == FILE_TYPE_HEX) - tempFile = tempDir + "/flash.hex"; + tempFile = generateProcessUniqueTempFileName("flash.hex"); else - tempFile = tempDir + "/flash.bin"; + tempFile = generateProcessUniqueTempFileName("flash.bin"); FlashInterface flash(fileName); flash.setSplash(image); if (flash.saveFlash(tempFile) > 0) { @@ -556,8 +555,7 @@ void burnDialog::on_BurnFlashButton_clicked() } if (patch) { - QString tempDir = QDir::tempPath(); - QString fileName = tempDir + "/temp.bin"; + QString fileName = generateProcessUniqueTempFileName("temp.bin"); QFile file(fileName); uint8_t *eeprom = (uint8_t*)malloc(GetEepromInterface()->getEEpromSize()); diff --git a/companion/src/comparedialog.cpp b/companion/src/comparedialog.cpp index 94197c382..b5f1c4feb 100644 --- a/companion/src/comparedialog.cpp +++ b/companion/src/comparedialog.cpp @@ -156,8 +156,8 @@ void CompareDialog::dropEvent(QDropEvent *event) void CompareDialog::closeEvent(QCloseEvent *event) { - unlink(curvefile5); - unlink(curvefile9); + qunlink(curvefile5); + qunlink(curvefile9); } CompareDialog::~CompareDialog() diff --git a/companion/src/helpers.cpp b/companion/src/helpers.cpp index f726949db..f8e4960a2 100644 --- a/companion/src/helpers.cpp +++ b/companion/src/helpers.cpp @@ -1,4 +1,11 @@ #include +#if defined WIN32 + #include + #include +#endif +#if !defined WIN32 && defined __GNUC__ + #include +#endif #include "appdata.h" #include "helpers.h" #include "simulatordialog.h" @@ -966,8 +973,16 @@ QString index2version(int index) } -int unlink(const QString & fileName) +int qunlink(const QString & fileName) { + qDebug() << "unlinking "<< fileName; QByteArray ba = fileName.toLatin1(); return unlink(ba.constData()); } + +QString generateProcessUniqueTempFileName(const QString & fileName) +{ + QString sanitizedFileName = fileName; + sanitizedFileName.remove('/'); + return QDir::tempPath() + QString("/%1-").arg(QCoreApplication::applicationPid()) + sanitizedFileName; +} diff --git a/companion/src/helpers.h b/companion/src/helpers.h index 5d33e1a0a..a6cabb8cf 100644 --- a/companion/src/helpers.h +++ b/companion/src/helpers.h @@ -140,6 +140,8 @@ class QTimeS : public QTime }; -int unlink(const QString & fileName); +int qunlink(const QString & fileName); + +QString generateProcessUniqueTempFileName(const QString & fileName); #endif // HELPERS_H diff --git a/companion/src/logsdialog.cpp b/companion/src/logsdialog.cpp index 37cc36619..d4ca6e913 100644 --- a/companion/src/logsdialog.cpp +++ b/companion/src/logsdialog.cpp @@ -239,13 +239,13 @@ void logsDialog::on_mapsButton_clicked() { itemSelected=n-1; } - QString geFilename = QDir::tempPath() + "/track0.png"; - if (QFile::exists(geFilename)) { - QFile::remove(geFilename); + QString geIconFilename = generateProcessUniqueTempFileName("track0.png"); + if (QFile::exists(geIconFilename)) { + QFile::remove(geIconFilename); } - QFile::copy(":/images/track0.png", geFilename); + QFile::copy(":/images/track0.png", geIconFilename); - geFilename = QDir::tempPath() + "/flight.kml"; + QString geFilename = generateProcessUniqueTempFileName("flight.kml"); if (QFile::exists(geFilename)) { QFile::remove(geFilename); } @@ -264,7 +264,7 @@ void logsDialog::on_mapsButton_clicked() { QTextStream outputStream(&geFile); outputStream << "\n\n"; outputStream << "\t\n\t\t" << logFilename << "\n"; - outputStream << "\t\t\n"; + outputStream << "\t\t\n"; outputStream << "\t\t\n"; outputStream << "\t\t\n\t\t\t\n\t\t\t\tnormal\n\t\t\t\t#multiTrack_n\n\t\t\t\n\t\t\t\n\t\t\t\thighlight\n\t\t\t\t#multiTrack_h\n\t\t\t\n\t\t\n"; outputStream << "\t\t\n"; diff --git a/companion/src/mainwindow.cpp b/companion/src/mainwindow.cpp index d48be68bb..e05c013d8 100644 --- a/companion/src/mainwindow.cpp +++ b/companion/src/mainwindow.cpp @@ -804,9 +804,9 @@ QStringList MainWindow::GetSambaArguments(const QString &tcl) { QStringList result; - QString tclFilename = QDir::tempPath() + "/temp.tcl"; + QString tclFilename = generateProcessUniqueTempFileName("temp.tcl"); if (QFile::exists(tclFilename)) { - unlink(tclFilename); + qunlink(tclFilename); } QFile tclFile(tclFilename); if (!tclFile.open(QIODevice::WriteOnly | QIODevice::Text)) { @@ -946,15 +946,14 @@ QString MainWindow::FindMassstoragePath(QString filename) void MainWindow::readEeprom() { - QString tempDir = QDir::tempPath(); - QString tempFile = tempDir + QString("/temp-%1").arg(QCoreApplication::applicationPid());; + QString tempFile; EEPROMInterface *eepromInterface = GetEepromInterface(); if (IS_ARM(eepromInterface->getBoard())) - tempFile += ".bin"; + tempFile = generateProcessUniqueTempFileName("temp.bin"); else - tempFile += ".hex"; + tempFile += generateProcessUniqueTempFileName("temp.hex"); qDebug() << "MainWindow::readEeprom(): using temp file: " << tempFile; @@ -963,7 +962,7 @@ void MainWindow::readEeprom() child->newFile(); child->loadFile(tempFile, false); child->show(); - unlink(tempFile); + qunlink(tempFile); } } @@ -1171,13 +1170,12 @@ void MainWindow::writeBackup() return; } int oldrev = getEpromVersion(fileName); - QString tempDir = QDir::tempPath(); - QString tempFlash = tempDir + QString("/flash-%1.bin").arg(QCoreApplication::applicationPid()); + QString tempFlash = generateProcessUniqueTempFileName("flash.bin"); if (!readFirmwareFromRadio(tempFlash)) return; - QString restoreFile = tempDir + QString("/compat.bin-%1.bin").arg(QCoreApplication::applicationPid()); + QString restoreFile = generateProcessUniqueTempFileName("compat.bin"); if (!convertEEPROM(fileName, restoreFile, tempFlash)) { int ret = QMessageBox::question(this, "Error", tr("Cannot check Models and Settings compatibility! Continue anyway?") , QMessageBox::Yes | QMessageBox::No); @@ -1194,7 +1192,7 @@ void MainWindow::writeBackup() } fileName = restoreFile; } - unlink(tempFlash); + qunlink(tempFlash); } else { if (backupEnable) { @@ -1308,8 +1306,7 @@ void MainWindow::writeFlash(QString fileToFlash) if (!fileName.isEmpty()) { g.backupOnFlash(backup); if (backup) { - QString tempDir = QDir::tempPath(); - QString backupFile = tempDir + "/backup.bin"; + QString backupFile = generateProcessUniqueTempFileName("backup.bin"); bool backupEnable=g.enableBackup(); QString backupPath=g.backupDir(); if (!backupPath.isEmpty() && !IS_TARANIS(GetEepromInterface()->getBoard())) { @@ -1334,7 +1331,7 @@ void MainWindow::writeFlash(QString fileToFlash) sleep(2); int res = writeFirmwareToRadio(fileName); if (res) { - QString restoreFile = tempDir + "/restore.bin"; + QString restoreFile = generateProcessUniqueTempFileName("restore.bin"); if (!convertEEPROM(backupFile, restoreFile, fileName)) { QMessageBox::warning(this, tr("Conversion failed"), tr("Cannot convert Models and Settings for use with this firmware, original data will be used")); restoreFile = backupFile; diff --git a/companion/src/mdichild.cpp b/companion/src/mdichild.cpp index a62be58e0..42f3fa8d1 100644 --- a/companion/src/mdichild.cpp +++ b/companion/src/mdichild.cpp @@ -531,8 +531,7 @@ void MdiChild::writeEeprom() // write to Tx } QString stickCal=g.profile[g.id()].stickPotCalib(); burnConfigDialog bcd; - QString tempDir = QDir::tempPath(); - QString tempFile = tempDir + "/temp.bin"; + QString tempFile = generateProcessUniqueTempFileName("temp.bin"); saveFile(tempFile, false); if(!QFileInfo(tempFile).exists()) { QMessageBox::critical(this,tr("Error"), tr("Cannot write temporary file!")); @@ -550,12 +549,12 @@ void MdiChild::writeEeprom() // write to Tx return; } int oldrev=((MainWindow *)this->parent())->getEpromVersion(tempFile); - QString tempFlash=tempDir + "/flash.bin"; + QString tempFlash = generateProcessUniqueTempFileName("flash.bin"); if (!((MainWindow *)this->parent())->readFirmwareFromRadio(tempFlash)) return; - QString restoreFile = tempDir + "/compat.bin"; + QString restoreFile = generateProcessUniqueTempFileName("compat.bin"); if (!((MainWindow *)this->parent())->convertEEPROM(tempFile, restoreFile, tempFlash)) { int ret = QMessageBox::question(this, tr("Error"), tr("Cannot check eeprom compatibility! Continue anyway?"), QMessageBox::Yes | QMessageBox::No); if (ret == QMessageBox::No) @@ -571,7 +570,7 @@ void MdiChild::writeEeprom() // write to Tx } tempFile=restoreFile; } - unlink(tempFlash); + qunlink(tempFlash); } else { if (backupEnable) { diff --git a/companion/src/printdialog.cpp b/companion/src/printdialog.cpp index 2e8d281b1..a8f42b0fc 100644 --- a/companion/src/printdialog.cpp +++ b/companion/src/printdialog.cpp @@ -31,12 +31,12 @@ PrintDialog::PrintDialog(QWidget *parent, FirmwareInterface * firmware, GeneralS te->clear(); QString modelname=g_model->name; if (modelname.isEmpty()) { - curvefile5=QString("%1/curve5.png").arg(qd->tempPath()); - curvefile9=QString("%1/curve9.png").arg(qd->tempPath()); + curvefile5=generateProcessUniqueTempFileName("curve5.png"); + curvefile9=generateProcessUniqueTempFileName("curve9.png"); } else { - curvefile5=QString("%1/%2-curve5.png").arg(qd->tempPath()).arg(modelname); - curvefile9=QString("%1/%2-curve9.png").arg(qd->tempPath()).arg(modelname); + curvefile5=generateProcessUniqueTempFileName(QString("%1-curve5.png").arg(modelname)); + curvefile9=generateProcessUniqueTempFileName(QString("%1-curve9.png").arg(modelname)); } printSetup(); if (gvars) { @@ -60,15 +60,16 @@ PrintDialog::PrintDialog(QWidget *parent, FirmwareInterface * firmware, GeneralS void PrintDialog::closeEvent(QCloseEvent *event) { - if (printfilename.isEmpty()) { - unlink(curvefile5); - unlink(curvefile9); - } + // if (printfilename.isEmpty()) { + // } } PrintDialog::~PrintDialog() { - delete ui; + qDebug() << "PrintDialog::~PrintDialog"; + qunlink(curvefile5); + qunlink(curvefile9); + delete ui; } QString doTC(const QString s, const QString color="", bool bold=false) From 8bd2c120d6121a677c050c1e8b0afb8cdc023d6b Mon Sep 17 00:00:00 2001 From: Damjan Adamic Date: Sun, 3 Aug 2014 19:27:02 +0200 Subject: [PATCH 5/5] Re #1567: cleanup --- companion/src/comparedialog.cpp | 4 ++-- companion/src/helpers.cpp | 1 - companion/src/helpers.h | 1 - companion/src/printdialog.cpp | 4 +--- 4 files changed, 3 insertions(+), 7 deletions(-) diff --git a/companion/src/comparedialog.cpp b/companion/src/comparedialog.cpp index b5f1c4feb..e93ded239 100644 --- a/companion/src/comparedialog.cpp +++ b/companion/src/comparedialog.cpp @@ -156,12 +156,12 @@ void CompareDialog::dropEvent(QDropEvent *event) void CompareDialog::closeEvent(QCloseEvent *event) { - qunlink(curvefile5); - qunlink(curvefile9); } CompareDialog::~CompareDialog() { + qunlink(curvefile5); + qunlink(curvefile9); delete ui; } diff --git a/companion/src/helpers.cpp b/companion/src/helpers.cpp index f8e4960a2..1949aca83 100644 --- a/companion/src/helpers.cpp +++ b/companion/src/helpers.cpp @@ -972,7 +972,6 @@ QString index2version(int index) } } - int qunlink(const QString & fileName) { qDebug() << "unlinking "<< fileName; diff --git a/companion/src/helpers.h b/companion/src/helpers.h index a6cabb8cf..a135dc2d8 100644 --- a/companion/src/helpers.h +++ b/companion/src/helpers.h @@ -139,7 +139,6 @@ class QTimeS : public QTime int seconds() const { return hour()*3600 + minute()*60 + second(); }; }; - int qunlink(const QString & fileName); QString generateProcessUniqueTempFileName(const QString & fileName); diff --git a/companion/src/printdialog.cpp b/companion/src/printdialog.cpp index a8f42b0fc..75593882d 100644 --- a/companion/src/printdialog.cpp +++ b/companion/src/printdialog.cpp @@ -60,13 +60,11 @@ PrintDialog::PrintDialog(QWidget *parent, FirmwareInterface * firmware, GeneralS void PrintDialog::closeEvent(QCloseEvent *event) { - // if (printfilename.isEmpty()) { - // } } PrintDialog::~PrintDialog() { - qDebug() << "PrintDialog::~PrintDialog"; + // notice PrintDialog::closeEvent() is not called if user clicks on Close button qunlink(curvefile5); qunlink(curvefile9); delete ui;