Mirror/pmbootstrap
1
0
Fork 1
mirror of https://gitlab.postmarketos.org/postmarketOS/pmbootstrap.git synced 2025-07-23 12:35:12 +03:00
Code Issues Wiki Activity

pmbootstrap: fix running ssh in a user namespace

Browse source 
Since we are root in the namespace, ssh will attempt to use the root
users config, additionally the ssh_config.d directory will have invalid
permissions (since it's owned by root on the host which is not mapped
into the userns).

Hack around all of these with some fancy mounts in the sandbox.

The "proper" way to do this would be to stop using the host rootfs
alltogether and unshare ourselves into an Alpine chroot, with the
users .ssh directory mounted in. But that will require refactoring
pmbootstrap's init code to be able to parse args and do actions before
entering the namespace.

Signed-off-by: Casey Connolly <kcxt@postmarketos.org>
This commit is contained in:
Casey Connolly 2025-06-20 22:14:25 +02:00
parent c83340b403
commit 4210e98c02
1 changed files with 33 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

33
pmbootstrap.py
View file

@ -61,6 +61,17 @@ if pid > 0:
# print(f"cap_sys_admin: {sandbox.have_effective_cap(sandbox.CAP_SYS_ADMIN)}")
# print(f"single user: {sandbox.userns_has_single_user()}")
def create_stub_passwd() -> str:
"""
Create a version of passwd where the root user home dir is replaced with our user
home dir, so that commands like ssh with read the right configs.
"""
return "".join(map(
lambda x: x.replace(":/root:", f":{os.environ['HOME']}:")
if x.startswith("root:") else x,
open("/etc/passwd").readlines()))
# We set up a very basic mount environment, where we just bind mount the host
# rootfs in. We can extend this in the future to isolate the pmb workdir but
# for now this is enough.
@ -77,6 +88,28 @@ fsops = [
# /tmp/pmb is a tmpfs we can use for scratch data that will be removed
# on exit.
sandbox.TmpfsOperation("/tmp/pmb"),
# We need to make /etc/ssh/ssh_config.d appear empty because permissions
# are all messed up. Probably there's a fancy way to mount with adjusted
# perms but for now this will do...
sandbox.DirOperation("/tmp/pmb/empty"),
sandbox.BindOperation(
"/tmp/pmb/empty",
"/etc/ssh/ssh_config.d",
readonly=True,
required=True,
relative=True
),
sandbox.WriteOperation(
create_stub_passwd(),
"/tmp/pmb/etc_passwd",
),
sandbox.BindOperation(
"/tmp/pmb/etc_passwd",
"/etc/passwd",
readonly=True,
required=True,
relative=True
),
]
sandbox.setup_mounts(fsops)