Mirror/pmbootstrap
1
0
Fork 1
mirror of https://gitlab.postmarketos.org/postmarketOS/pmbootstrap.git synced 2025-07-13 03:19:47 +03:00
Code Issues Wiki Activity

pmb.sideload: Query architecture from foreign device (MR 2282)

Browse source 
Instead of assuming the architecture of the foreign device to be what
the user selected in pmbootstrap init, actually query the architecture
from the device and use that.

This does mean that one extra ssh connection is necessary, which does
slow down the procedure somewhat. However, I think that is worth the
user experience improvement this brings.

Also, the deduction process can be skipped by manually specifying
--arch in the sideload invocation should it fail, or if one really wants
to skip that extra ssh roundtrip.

Related: https://gitlab.com/postmarketOS/pmbootstrap/-/issues/2317
This commit is contained in:
Newbyte 2024-03-23 14:51:35 +01:00
parent 1fc83f8bce
commit c2a069b1f5
No known key found for this signature in database
GPG key ID: 8A700086A9FE41FD
3 changed files with 18 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
pmb/parse/arguments.py
View file

@ -220,8 +220,8 @@ def arguments_sideload(subparser):
default="22")
ret.add_argument("--user", help="use a different username than the"
" one set in init")
ret.add_argument("--arch", help="use a different architecture than the one"
" set in init")
ret.add_argument("--arch", help="skip automatic architecture deduction and use the"
" given value")
ret.add_argument("--install-key", help="install the apk key from this"
" machine if needed",
action="store_true", dest="install_key")