NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

android: camera_request: Turn struct into a class

Browse source 
The Camera3RequestDescriptor structure is growing into an object with
member functions. Turn it into a class, uninline the destructor to
reduce code size, explicitly disable copy as requests are not copyable,
and delete the default constructor to force all instances to be fully
constructed.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
This commit is contained in:
Laurent Pinchart 2021-10-19 17:17:52 +05:30 • committed by Umang Jain
parent 109a98e8c0
commit 030c8f1a7e
3 changed files with 15 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/android/camera_request.h
View file

@ -10,6 +10,8 @@
#include <memory>
#include <vector>
#include <libcamera/base/class.h>
#include <libcamera/camera.h>
#include <libcamera/framebuffer.h>
@ -18,18 +20,18 @@
#include "camera_metadata.h"
#include "camera_worker.h"
struct Camera3RequestDescriptor {
class Camera3RequestDescriptor
{
public:
enum class Status {
Pending,
Success,
Error,
};
Camera3RequestDescriptor() = default;
~Camera3RequestDescriptor() = default;
Camera3RequestDescriptor(libcamera::Camera *camera,
const camera3_capture_request_t *camera3Request);
Camera3RequestDescriptor &operator=(Camera3RequestDescriptor &&) = default;
~Camera3RequestDescriptor();
bool isPending() const { return status_ == Status::Pending; }
@ -41,6 +43,9 @@ struct Camera3RequestDescriptor {
camera3_capture_result_t captureResult_ = {};
Status status_ = Status::Pending;
private:
LIBCAMERA_DISABLE_COPY(Camera3RequestDescriptor)
};
#endif /* __ANDROID_CAMERA_REQUEST_H__ */