NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

ipa: ipu3: awb: Correct the gain multipliers

Browse source 
The gains have a precision u3.13, range [0, 8[ which means that a gain
multiplier value of 1.0 is represented as a multiplication by 8192 in
the ImgU. Correct the gains as this was misunderstood in the first
place.

Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Jean-Michel Hautbois 2021-08-23 08:25:26 +02:00
parent 3a240e56a8
commit 03132d0ff9
1 changed files with 6 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/ipa/ipu3/algorithms/awb.cpp
View file

@ -317,6 +317,7 @@ void Awb::awbGreyWorld()
/* Color temperature is not relevant in Grey world but still useful to estimate it :-) */ /* Color temperature is not relevant in Grey world but still useful to estimate it :-) */
asyncResults_.temperatureK = estimateCCT(sumRed.R, sumRed.G, sumBlue.B); asyncResults_.temperatureK = estimateCCT(sumRed.R, sumRed.G, sumBlue.B);
asyncResults_.redGain = redGain; asyncResults_.redGain = redGain;
/* Hardcode the green gain to 1.0. */
asyncResults_.greenGain = 1.0; asyncResults_.greenGain = 1.0;
asyncResults_.blueGain = blueGain; asyncResults_.blueGain = blueGain;
} }
@ -380,15 +381,11 @@ void Awb::prepare(IPAContext &context, ipu3_uapi_params *params)
* params->acc_param.bnr.opt_center.x_reset; * params->acc_param.bnr.opt_center.x_reset;
params->acc_param.bnr.opt_center_sqr.y_sqr_reset = params->acc_param.bnr.opt_center.y_reset params->acc_param.bnr.opt_center_sqr.y_sqr_reset = params->acc_param.bnr.opt_center.y_reset
* params->acc_param.bnr.opt_center.y_reset; * params->acc_param.bnr.opt_center.y_reset;
/* /* Convert to u3.13 fixed point values */
* Green gains should not be touched and considered 1. params->acc_param.bnr.wb_gains.gr = 8192 * context.frameContext.awb.gains.green;
* Default is 16, so do not change it at all. params->acc_param.bnr.wb_gains.r = 8192 * context.frameContext.awb.gains.red;
* 4096 is the value for a gain of 1.0 params->acc_param.bnr.wb_gains.b = 8192 * context.frameContext.awb.gains.blue;
*/ params->acc_param.bnr.wb_gains.gb = 8192 * context.frameContext.awb.gains.green;
params->acc_param.bnr.wb_gains.gr = 16 * context.frameContext.awb.gains.green;
params->acc_param.bnr.wb_gains.r = 4096 * context.frameContext.awb.gains.red;
params->acc_param.bnr.wb_gains.b = 4096 * context.frameContext.awb.gains.blue;
params->acc_param.bnr.wb_gains.gb = 16 * context.frameContext.awb.gains.green;
LOG(IPU3Awb, Debug) << "Color temperature estimated: " << asyncResults_.temperatureK; LOG(IPU3Awb, Debug) << "Color temperature estimated: " << asyncResults_.temperatureK;