NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libcamera: v4l2_videodevice: provide hasMediaController()

Browse source 
The V4L2Capability has helpers to interogate the capabilities
of a device.

V4L2VideoDevice::enumPixelformats accesses the raw capabilites to check
if the device is supported by a MediaController device.

Provide a helper, and update the usage.

Reviewed-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Kieran Bingham 2021-10-27 13:03:53 +01:00
parent 4d4694cd9f
commit 0a1aaa8d55
2 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
include/libcamera/internal/v4l2_videodevice.h
View file

@ -109,6 +109,10 @@ struct V4L2Capability final : v4l2_capability {
{ {
return device_caps() & V4L2_CAP_STREAMING; return device_caps() & V4L2_CAP_STREAMING;
} }
bool hasMediaController() const
{
return device_caps() & V4L2_CAP_IO_MC;
}
}; };
class V4L2BufferCache class V4L2BufferCache

8
src/libcamera/v4l2_videodevice.cpp
View file

@ -140,6 +140,12 @@ LOG_DECLARE_CATEGORY(V4L2)
* \return True if the video device provides Streaming I/O IOCTLs * \return True if the video device provides Streaming I/O IOCTLs
*/ */
/**
* \fn V4L2Capability::hasMediaController()
* \brief Determine if the video device uses Media Controller to configure I/O
* \return True if the video device is controlled by a Media Controller device
*/
/** /**
* \class V4L2BufferCache * \class V4L2BufferCache
* \brief Hot cache of associations between V4L2 buffer indexes and FrameBuffer * \brief Hot cache of associations between V4L2 buffer indexes and FrameBuffer
@ -1019,7 +1025,7 @@ std::vector<V4L2PixelFormat> V4L2VideoDevice::enumPixelformats(uint32_t code)
std::vector<V4L2PixelFormat> formats; std::vector<V4L2PixelFormat> formats;
int ret; int ret;
if (code && !(caps_.device_caps() & V4L2_CAP_IO_MC)) { if (code && !caps_.hasMediaController()) {
LOG(V4L2, Error) LOG(V4L2, Error)
<< "Media bus code filtering not supported by the device"; << "Media bus code filtering not supported by the device";
return {}; return {};