NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

ipa: rkisp1: Do not set controls during configure

Browse source 
Do not send events back to the pipeline handler, while the IPA thread
has not been started.

If information needs to be returned from configure it should be returned
directly.

Move the initial call to setControls() out of configure() and into the
start() method which is called after the IPA running_ state is updated.

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Signed-off-by: Sebastian Fricke <sebastian.fricke@posteo.net>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Sebastian Fricke 2021-03-27 11:08:13 +01:00 • committed by Kieran Bingham
parent 92cad298fb
commit 1456efe7d5
1 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/ipa/rkisp1/rkisp1.cpp
View file

@ -32,7 +32,7 @@ class IPARkISP1 : public ipa::rkisp1::IPARkISP1Interface
{ {
public: public:
int init(unsigned int hwRevision) override; int init(unsigned int hwRevision) override;
int start() override { return 0; } int start() override;
void stop() override {} void stop() override {}
int configure(const CameraSensorInfo &info, int configure(const CameraSensorInfo &info,
@ -80,6 +80,13 @@ int IPARkISP1::init(unsigned int hwRevision)
return 0; return 0;
} }
int IPARkISP1::start()
{
setControls(0);
return 0;
}
/** /**
* \todo The RkISP1 pipeline currently provides an empty CameraSensorInfo * \todo The RkISP1 pipeline currently provides an empty CameraSensorInfo
* if the connected sensor does not provide enough information to properly * if the connected sensor does not provide enough information to properly
@ -121,7 +128,6 @@ int IPARkISP1::configure([[maybe_unused]] const CameraSensorInfo &info,
<< "Exposure: " << minExposure_ << "-" << maxExposure_ << "Exposure: " << minExposure_ << "-" << maxExposure_
<< " Gain: " << minGain_ << "-" << maxGain_; << " Gain: " << minGain_ << "-" << maxGain_;
setControls(0);
return 0; return 0;
} }