NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

test: Remove using namespace in header files

Browse source 
"using namespace" in a header file propagates the namespace to
the files including the header file. So it should be avoided.
This removes "using namespace" in header files in test.

Signed-off-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Hirokazu Honda 2021-10-05 16:31:14 +09:00 • committed by Laurent Pinchart
parent af60569cbc
commit 1526650fc7
16 changed files with 33 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

2
test/libtest/buffer_source.cpp
View file

@ -14,6 +14,8 @@
#include "test.h"
using namespace libcamera;
BufferSource::BufferSource()
{
}

10
test/libtest/buffer_source.h
View file

@ -12,20 +12,18 @@
#include "libcamera/internal/media_device.h"
#include "libcamera/internal/v4l2_videodevice.h"
using namespace libcamera;
class BufferSource
{
public:
BufferSource();
~BufferSource();
int allocate(const StreamConfiguration &config);
const std::vector<std::unique_ptr<FrameBuffer>> &buffers();
int allocate(const libcamera::StreamConfiguration &config);
const std::vector<std::unique_ptr<libcamera::FrameBuffer>> &buffers();
private:
std::shared_ptr<MediaDevice> media_;
std::vector<std::unique_ptr<FrameBuffer>> buffers_;
std::shared_ptr<libcamera::MediaDevice> media_;
std::vector<std::unique_ptr<libcamera::FrameBuffer>> buffers_;
};
#endif /* __LIBCAMERA_BUFFER_SOURCE_TEST_H__ */

6
test/libtest/camera_test.h
View file

@ -12,8 +12,6 @@
#include <libcamera/camera.h>
#include <libcamera/camera_manager.h>
using namespace libcamera;
class CameraTest
{
public:
@ -21,8 +19,8 @@ public:
~CameraTest();
protected:
CameraManager *cm_;
std::shared_ptr<Camera> camera_;
libcamera::CameraManager *cm_;
std::shared_ptr<libcamera::Camera> camera_;
int status_;
};