NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

test: gstreamer: Remove videoconvert element from pipeline

Browse source 
The GStreamer single stream test uses the following pipeline:

	libcamerasrc ! videoconvert ! fakesink

The videoconvert element isn't useful as the data is thrown away by the
fakesink anyway. We can shorten the pipeline to

	libcamerasrc ! fakesink

to save CPU time and to avoid depending on the gstreamer1.0-plugins-base
package to run the unit tests.

The test could be further simplified by replacing
gst_parse_bin_from_description_full() with gst_element_factory_make(),
now that we only add one element to the bin. The extra cost incurred by
the bin only impacts initialization time, and using a bin will make it
easier to add other elements in the future if needed. Keep the bin, and
only drop the videoconvert element.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Laurent Pinchart 2023-12-06 22:02:36 +02:00
parent efcda47985
commit 17d8b89deb
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
test/gstreamer/gstreamer_single_stream_test.cpp
View file

@ -29,7 +29,7 @@ protected:
if (status_ != TestPass)
return status_;
const gchar *streamDescription = "videoconvert ! fakesink";
const gchar *streamDescription = "fakesink";
g_autoptr(GError) error0 = NULL;
stream0_ = gst_parse_bin_from_description_full(streamDescription, TRUE,
NULL,