NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libcamera: media_device: Initialise local variable

Browse source 
The local variable ifaceId generates a compiler warning that it is used
without initialisation.

The loop, and check against the loop iterator, and the
topology.num_interfaces actually ensures that this isn't the case, and
that ifaceId can only be used when set to a valid ID.

The media_v2_interface.id field documents the ID as simply "Unique ID
for the interface" but does not specify if zero is a valid ID or not. As
such we don't further check the pre-initialised ID for validity and keep
the existing check on the iterator count to determine if the ID had been
discovered successfully.

Fixes: d4af90d729 ("libcamera: media_device: Create entities with
major and minor numbers")

Acked-by: Jacopo Mondi <jacopo@jmondi.org>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Kieran Bingham 2019-03-19 11:32:09 +00:00
parent af2144231e
commit 18647a5324
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/libcamera/media_device.cpp
View file

@ -516,7 +516,7 @@ struct media_v2_interface *MediaDevice::findInterface(const struct media_v2_topo
{ {
struct media_v2_link *links = reinterpret_cast<struct media_v2_link *> struct media_v2_link *links = reinterpret_cast<struct media_v2_link *>
(topology.ptr_links); (topology.ptr_links);
unsigned int ifaceId; unsigned int ifaceId = 0;
unsigned int i; unsigned int i;
for (i = 0; i < topology.num_links; ++i) { for (i = 0; i < topology.num_links; ++i) {