test: camera: buffer_import: clear video pointer

The FrameSink::cleanup() call checks if video_ is set before cleaning up
and then deleting the object.

If the cleanup() call is called twice for any reason, this will
encounter a use-after-free as the video_ pointer is not cleared after
deletion.

Whilst cleanup() is not currently called twice consecutively, to prevent
errors in the future, make it explicit that the object has been deleted
by clearing the stale pointer.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Kieran Bingham 2019-07-18 04:07:30 +01:00
parent 119428fa1c
commit 1a6b80e4a0

View file

@ -109,7 +109,9 @@ public:
video_->streamOff();
video_->releaseBuffers();
video_->close();
delete video_;
video_ = nullptr;
}
if (media_)