NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

ipa: raspberrypi: Remove generic "pause" mechanism from Algorithm

Browse source 
No existing Algorithm used the base pause(), resume() functions
or the paused_ flag, nor is there a need for a generic pause API.
Remove these. The AGC and AWB algorithms now have methods named
disableAuto(), enableAuto() which better describe their functionality.

Signed-off-by: Nick Hollinghurst <nick.hollinghurst@raspberrypi.com>
Reviewed-by: David Plowman <david.plowman@raspberrypi.com>
Reviewed-by: Naushir Patuck <naush@raspberrypi.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Nick Hollinghurst 2022-11-21 14:47:29 +00:00 • committed by Laurent Pinchart
parent 47c53f8084
commit 1bcb7539df
9 changed files with 26 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/ipa/raspberrypi/controller/rpi/agc.cpp
View file

@ -270,18 +270,13 @@ int Agc::read(const libcamera::YamlObject &params)
return 0;
}
bool Agc::isPaused() const
{
return false;
}
void Agc::pause()
void Agc::disableAuto()
{
fixedShutter_ = status_.shutterTime;
fixedAnalogueGain_ = status_.analogueGain;
}
void Agc::resume()
void Agc::enableAuto()
{
fixedShutter_ = 0s;
fixedAnalogueGain_ = 0;
@ -317,14 +312,14 @@ void Agc::setMaxShutter(Duration maxShutter)
void Agc::setFixedShutter(Duration fixedShutter)
{
fixedShutter_ = fixedShutter;
/* Set this in case someone calls Pause() straight after. */
/* Set this in case someone calls disableAuto() straight after. */
status_.shutterTime = clipShutter(fixedShutter_);
}
void Agc::setFixedAnalogueGain(double fixedAnalogueGain)
{
fixedAnalogueGain_ = fixedAnalogueGain;
/* Set this in case someone calls Pause() straight after. */
/* Set this in case someone calls disableAuto() straight after. */
status_.analogueGain = fixedAnalogueGain;
}