NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libcamera: v4l2_videodevice: lastUsedCounter_ need not be atomic

Browse source 
The `V4L2BufferCache` type is not thread-safe. Its `lastUsedCounter_`
member is not used in contexts where its atomicity would matter.
So it does not need to be have an atomic type.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Barnabás Pőcze 2025-03-07 16:00:21 +01:00
parent 90208694c8
commit 1df8091e63
2 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
include/libcamera/internal/v4l2_videodevice.h
View file

@ -8,7 +8,6 @@
#pragma once
#include <array>
#include <atomic>
#include <memory>
#include <optional>
#include <ostream>
@ -158,7 +157,7 @@ private:
std::vector<Plane> planes_;
};
std::atomic<uint64_t> lastUsedCounter_;
uint64_t lastUsedCounter_;
std::vector<Entry> cache_;
/* \todo Expose the miss counter through an instrumentation API. */
unsigned int missCounter_;