NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libcamera: base: log: Log to std::cerr if log file can't be opened

Browse source 
If the log file specified through LIBCAMERA_LOG_FILE can't be opened,
logging is currently completely disabled. This doesn't match the
documented behaviour that tells std::cerr is used instead. Fix it to
match the documentation.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
This commit is contained in:
Laurent Pinchart 2022-05-25 18:48:26 +03:00
parent 8a606e6c67
commit 207e52b8d3
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/libcamera/base/log.cpp
View file

@ -517,6 +517,8 @@ void Logger::logSetLevel(const char *category, const char *level)
*/ */
Logger::Logger() Logger::Logger()
{ {
logSetStream(&std::cerr);
parseLogFile(); parseLogFile();
parseLogLevels(); parseLogLevels();
} }
@ -533,10 +535,8 @@ Logger::Logger()
void Logger::parseLogFile() void Logger::parseLogFile()
{ {
const char *file = utils::secure_getenv("LIBCAMERA_LOG_FILE"); const char *file = utils::secure_getenv("LIBCAMERA_LOG_FILE");
if (!file) { if (!file)
logSetStream(&std::cerr);
return; return;
}
if (!strcmp(file, "syslog")) { if (!strcmp(file, "syslog")) {
logSetTarget(LoggingTargetSyslog); logSetTarget(LoggingTargetSyslog);