NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

pipeline: rkisp1: Fix stream size validation

Browse source 
Unlike RkISP1Path::generateConfiguration(), the validate() function
doesn't take the camera sensor resolution into account but only
considers the absolute minimum and maximum sizes supported by the ISP to
validate the stream size. Fix it by using the same logic as when
generating the configuration.

Instead of passing the sensor resolution to the validate() function,
pass the CameraSensor pointer to prepare for subsequent changes that
will require access to more camera sensor data. While at it, update the
generateConfiguration() function similarly for the same reason.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
This commit is contained in:
Laurent Pinchart 2022-10-23 05:36:38 +03:00
parent 4c30ed47f6
commit 2447d14fa8
3 changed files with 31 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

17
src/libcamera/pipeline/rkisp1/rkisp1.cpp
View file

@ -411,14 +411,15 @@ RkISP1CameraConfiguration::RkISP1CameraConfiguration(Camera *camera,
bool RkISP1CameraConfiguration::fitsAllPaths(const StreamConfiguration &cfg)
{
const CameraSensor *sensor = data_->sensor_.get();
StreamConfiguration config;
config = cfg;
if (data_->mainPath_->validate(&config) != Valid)
if (data_->mainPath_->validate(sensor, &config) != Valid)
return false;
config = cfg;
if (data_->selfPath_ && data_->selfPath_->validate(&config) != Valid)
if (data_->selfPath_ && data_->selfPath_->validate(sensor, &config) != Valid)
return false;
return true;
@ -466,7 +467,7 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()
/* Try to match stream without adjusting configuration. */
if (mainPathAvailable) {
StreamConfiguration tryCfg = cfg;
if (data_->mainPath_->validate(&tryCfg) == Valid) {
if (data_->mainPath_->validate(sensor, &tryCfg) == Valid) {
mainPathAvailable = false;
cfg = tryCfg;
cfg.setStream(const_cast<Stream *>(&data_->mainPathStream_));
@ -476,7 +477,7 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()
if (selfPathAvailable) {
StreamConfiguration tryCfg = cfg;
if (data_->selfPath_->validate(&tryCfg) == Valid) {
if (data_->selfPath_->validate(sensor, &tryCfg) == Valid) {
selfPathAvailable = false;
cfg = tryCfg;
cfg.setStream(const_cast<Stream *>(&data_->selfPathStream_));
@ -487,7 +488,7 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()
/* Try to match stream allowing adjusting configuration. */
if (mainPathAvailable) {
StreamConfiguration tryCfg = cfg;
if (data_->mainPath_->validate(&tryCfg) == Adjusted) {
if (data_->mainPath_->validate(sensor, &tryCfg) == Adjusted) {
mainPathAvailable = false;
cfg = tryCfg;
cfg.setStream(const_cast<Stream *>(&data_->mainPathStream_));
@ -498,7 +499,7 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()
if (selfPathAvailable) {
StreamConfiguration tryCfg = cfg;
if (data_->selfPath_->validate(&tryCfg) == Adjusted) {
if (data_->selfPath_->validate(sensor, &tryCfg) == Adjusted) {
selfPathAvailable = false;
cfg = tryCfg;
cfg.setStream(const_cast<Stream *>(&data_->selfPathStream_));
@ -610,11 +611,11 @@ PipelineHandlerRkISP1::generateConfiguration(Camera *camera,
StreamConfiguration cfg;
if (useMainPath) {
cfg = data->mainPath_->generateConfiguration(
data->sensor_->resolution());
data->sensor_.get());
mainPathAvailable = false;
} else {
cfg = data->selfPath_->generateConfiguration(
data->sensor_->resolution());
data->sensor_.get());
selfPathAvailable = false;
}

22
src/libcamera/pipeline/rkisp1/rkisp1_path.cpp
View file

@ -12,6 +12,7 @@
#include <libcamera/formats.h>
#include <libcamera/stream.h>
#include "libcamera/internal/camera_sensor.h"
#include "libcamera/internal/media_device.h"
#include "libcamera/internal/v4l2_subdevice.h"
#include "libcamera/internal/v4l2_videodevice.h"
@ -85,8 +86,10 @@ void RkISP1Path::populateFormats()
}
}
StreamConfiguration RkISP1Path::generateConfiguration(const Size &resolution)
StreamConfiguration RkISP1Path::generateConfiguration(const CameraSensor *sensor)
{
const Size &resolution = sensor->resolution();
Size maxResolution = maxResolution_.boundedToAspectRatio(resolution)
.boundedTo(resolution);
Size minResolution = minResolution_.expandedToAspectRatio(resolution);
@ -104,8 +107,11 @@ StreamConfiguration RkISP1Path::generateConfiguration(const Size &resolution)
return cfg;
}
CameraConfiguration::Status RkISP1Path::validate(StreamConfiguration *cfg)
CameraConfiguration::Status RkISP1Path::validate(const CameraSensor *sensor,
StreamConfiguration *cfg)
{
const Size &resolution = sensor->resolution();
const StreamConfiguration reqCfg = *cfg;
CameraConfiguration::Status status = CameraConfiguration::Valid;
@ -117,8 +123,16 @@ CameraConfiguration::Status RkISP1Path::validate(StreamConfiguration *cfg)
if (!streamFormats_.count(cfg->pixelFormat))
cfg->pixelFormat = formats::NV12;
cfg->size.boundTo(maxResolution_);
cfg->size.expandTo(minResolution_);
/*
* Adjust the size based on the sensor resolution and absolute limits
* of the ISP.
*/
Size maxResolution = maxResolution_.boundedToAspectRatio(resolution)
.boundedTo(resolution);
Size minResolution = minResolution_.expandedToAspectRatio(resolution);
cfg->size.boundTo(maxResolution);
cfg->size.expandTo(minResolution);
cfg->bufferCount = RKISP1_BUFFER_COUNT;
V4L2DeviceFormat format;

6
src/libcamera/pipeline/rkisp1/rkisp1_path.h
View file

@ -23,6 +23,7 @@
namespace libcamera {
class CameraSensor;
class MediaDevice;
class V4L2Subdevice;
struct StreamConfiguration;
@ -39,8 +40,9 @@ public:
int setEnabled(bool enable) { return link_->setEnabled(enable); }
bool isEnabled() const { return link_->flags() & MEDIA_LNK_FL_ENABLED; }
StreamConfiguration generateConfiguration(const Size &resolution);
CameraConfiguration::Status validate(StreamConfiguration *cfg);
StreamConfiguration generateConfiguration(const CameraSensor *sensor);
CameraConfiguration::Status validate(const CameraSensor *sensor,
StreamConfiguration *cfg);
int configure(const StreamConfiguration &config,
const V4L2SubdeviceFormat &inputFormat);