NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

ipa: rpi: Add hardware line rate constraints

Browse source 
Advertise hardware constraints on the pixel processing rate through the
Controller::HardwareConfig structure. When calculating the minimum line
length during a configure() operation, ensure that we don't exceed this
constraint.

If we do exceed the hardware constraints, increase the modes's minimum
line length so the pixel processing rate falls below the hardware limit.
If this is not possible, throw a loud error message in the logs.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: David Plowman <david.plowman@raspberrypi.com>
Reviewed-by: Nick Hollinghurst <nick.hollinghurst@raspberrypi.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Naushir Patuck 2024-01-04 11:38:55 +00:00 • committed by Laurent Pinchart
parent 577e0c6b76
commit 271598618d
3 changed files with 49 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

27
src/ipa/rpi/common/ipa_base.cpp
View file

@ -531,6 +531,33 @@ void IpaBase::setMode(const IPACameraSensorInfo &sensorInfo)
mode_.minLineLength = sensorInfo.minLineLength * (1.0s / sensorInfo.pixelRate);
mode_.maxLineLength = sensorInfo.maxLineLength * (1.0s / sensorInfo.pixelRate);
/*
* Ensure that the maximum pixel processing rate does not exceed the ISP
* hardware capabilities. If it does, try adjusting the minimum line
* length to compensate if possible.
*/
Duration minPixelTime = controller_.getHardwareConfig().minPixelProcessingTime;
Duration pixelTime = mode_.minLineLength / mode_.width;
if (minPixelTime && pixelTime < minPixelTime) {
Duration adjustedLineLength = minPixelTime * mode_.width;
if (adjustedLineLength <= mode_.maxLineLength) {
LOG(IPARPI, Info)
<< "Adjusting mode minimum line length from " << mode_.minLineLength
<< " to " << adjustedLineLength << " because of ISP constraints.";
mode_.minLineLength = adjustedLineLength;
} else {
LOG(IPARPI, Error)
<< "Sensor minimum line length of " << pixelTime * mode_.width
<< " (" << 1us / pixelTime << " MPix/s)"
<< " is below the minimum allowable ISP limit of "
<< adjustedLineLength
<< " (" << 1us / minPixelTime << " MPix/s) ";
LOG(IPARPI, Error)
<< "THIS WILL CAUSE IMAGE CORRUPTION!!! "
<< "Please update the camera sensor driver to allow more horizontal blanking control.";
}
}
/*
* Set the frame length limits for the mode to ensure exposure and
* framerate calculations are clipped appropriately.