NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libcamera: virtual: Avoid some copies

Browse source 
There is no reason make copies, these functions return
const lvalue references, access the data through those.

Signed-off-by: Barnabás Pőcze <pobrn@protonmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Barnabás Pőcze 2024-12-10 18:55:40 +01:00
parent 35ed4b9129
commit 277a28691c
3 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/libcamera/pipeline/virtual/image_frame_generator.cpp
View file

@ -129,7 +129,7 @@ int ImageFrameGenerator::generateFrame(const Size &size, const FrameBuffer *buff
MappedFrameBuffer mappedFrameBuffer(buffer, MappedFrameBuffer::MapFlag::Write); MappedFrameBuffer mappedFrameBuffer(buffer, MappedFrameBuffer::MapFlag::Write);
auto planes = mappedFrameBuffer.planes(); const auto &planes = mappedFrameBuffer.planes();
/* Loop only around the number of images available */ /* Loop only around the number of images available */
frameIndex_ %= imageFrameDatas_.size(); frameIndex_ %= imageFrameDatas_.size();

2
src/libcamera/pipeline/virtual/test_pattern_generator.cpp
View file

@ -25,7 +25,7 @@ int TestPatternGenerator::generateFrame(const Size &size,
MappedFrameBuffer mappedFrameBuffer(buffer, MappedFrameBuffer mappedFrameBuffer(buffer,
MappedFrameBuffer::MapFlag::Write); MappedFrameBuffer::MapFlag::Write);
auto planes = mappedFrameBuffer.planes(); const auto &planes = mappedFrameBuffer.planes();
shiftLeft(size); shiftLeft(size);

3
src/libcamera/pipeline/virtual/virtual.cpp
View file

@ -275,8 +275,7 @@ int PipelineHandlerVirtual::exportFrameBuffers([[maybe_unused]] Camera *camera,
return -ENOBUFS; return -ENOBUFS;
const StreamConfiguration &config = stream->configuration(); const StreamConfiguration &config = stream->configuration();
const PixelFormatInfo &info = PixelFormatInfo::info(config.pixelFormat);
auto info = PixelFormatInfo::info(config.pixelFormat);
std::vector<unsigned int> planeSizes; std::vector<unsigned int> planeSizes;
for (size_t i = 0; i < info.planes.size(); ++i) for (size_t i = 0; i < info.planes.size(); ++i)