NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

utils: ipc: Initialise ThreadProxy

Browse source 
The ThreadProxy IPA template does not implement a constructor and the
default compiler generated constructor does not initialise the private
ipa_ pointer.

Whilst this should not be expected to be used while uninitialised, it
does get caught by static analysis for every IPA module constructed, so
lets be clean and fix it.

Reported-by: Coverity CID=350116
Reported-by: Coverity CID=350123
Reported-by: Coverity CID=350140
Reported-by: Coverity CID=350147
Fixes: 7832e19a59 ("utils: ipc: add templates for code generation for IPC mechanism")
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Kieran Bingham 2021-07-13 12:01:31 +01:00
parent 0e8d8fbd4e
commit 2c18ebb859
1 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
utils/ipc/generators/libcamera_templates/module_ipa_proxy.h.tmpl
View file

@ -72,6 +72,11 @@ private:
class ThreadProxy : public Object class ThreadProxy : public Object
{ {
public: public:
ThreadProxy()
: ipa_(nullptr)
{
}
void setIPA({{interface_name}} *ipa) void setIPA({{interface_name}} *ipa)
{ {
ipa_ = ipa; ipa_ = ipa;