NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libcamera: v4l2_device: Fix getFormatSingleplane ioctl

Browse source 
The single plane getFormat() function wrongly used the VIDIOC_S_FMT ioctl.
Fix that by using the more opportune VIDIOC_G_FMT one.

Fixes: ba8da0f2fc ("libcamera: v4l2_device: Add methods to get/set format")
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
This commit is contained in:
Jacopo Mondi 2019-01-31 17:28:04 +01:00
parent a78e56ecc2
commit 2f516306a7
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/libcamera/v4l2_device.cpp
View file

@ -305,7 +305,7 @@ int V4L2Device::getFormatSingleplane(V4L2DeviceFormat *fmt)
int ret;
v4l2Fmt.type = bufferType_;
ret = ioctl(fd_, VIDIOC_S_FMT, &v4l2Fmt);
ret = ioctl(fd_, VIDIOC_G_FMT, &v4l2Fmt);
if (ret) {
ret = -errno;
LOG(Error) << "Unable to get format: " << strerror(-ret);