NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

test: v4l2_subdevice: list_formats: Port to use utils::hex() output helper

Browse source 
The hex stream output helper was introduced in f391048a7b ("libcamera: utils:
Add hex stream output helper"). It simplifies writing hexadecimal values to an
ostream which can be used in this test too. As the helper doesn't modify the
stream configuration (refer to utils::hex() documentation), this eliminates the
need of restoring the stream's format state as pointed out by the coverity scan.

Reported-by: Coverity CID=279058
Signed-off-by: Umang Jain <email@uajain.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Umang Jain 2020-06-08 15:22:10 +00:00 • committed by Kieran Bingham
parent 071e3698f5
commit 313d65ca25
1 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
test/v4l2_subdevice/list_formats.cpp
View file

@ -5,12 +5,12 @@
* libcamera V4L2 Subdevice format handling test
*/
#include <iomanip>
#include <iostream>
#include <vector>
#include <libcamera/geometry.h>
#include "libcamera/internal/utils.h"
#include "libcamera/internal/v4l2_subdevice.h"
#include "v4l2_subdevice_test.h"
@ -36,8 +36,7 @@ void ListFormatsTest::printFormats(unsigned int pad,
{
cout << "Enumerate formats on pad " << pad << endl;
for (const SizeRange &size : sizes) {
cout << " mbus code: 0x" << setfill('0') << setw(4)
<< hex << code << endl;
cout << " mbus code: " << utils::hex(code, 4) << endl;
cout << " min width: " << dec << size.min.width << endl;
cout << " min height: " << dec << size.min.height << endl;
cout << " max width: " << dec << size.max.width << endl;