NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libcamera: converter_v4l2_m2m: Add missing override specifier

Browse source 
In preparation for adding new functions and overrides to the
V4L2M2MDevice class, add an override specifier to all overridden
functions in the class. This prevents -Winconsistent-missing-override
warnings.

Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
This commit is contained in:
Stefan Klug 2024-12-16 16:40:46 +01:00
parent 60bb16695e
commit 366dad2536
1 changed files with 13 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

25
include/libcamera/internal/converter/converter_v4l2_m2m.h
View file

@ -38,28 +38,29 @@ class V4L2M2MConverter : public Converter
public: public:
V4L2M2MConverter(MediaDevice *media); V4L2M2MConverter(MediaDevice *media);
int loadConfiguration([[maybe_unused]] const std::string &filename) { return 0; } int loadConfiguration([[maybe_unused]] const std::string &filename) override { return 0; }
bool isValid() const { return m2m_ != nullptr; } bool isValid() const override { return m2m_ != nullptr; }
std::vector<PixelFormat> formats(PixelFormat input); std::vector<PixelFormat> formats(PixelFormat input) override;
SizeRange sizes(const Size &input); SizeRange sizes(const Size &input) override;
std::tuple<unsigned int, unsigned int> std::tuple<unsigned int, unsigned int>
strideAndFrameSize(const PixelFormat &pixelFormat, const Size &size); strideAndFrameSize(const PixelFormat &pixelFormat, const Size &size) override;
int configure(const StreamConfiguration &inputCfg, int configure(const StreamConfiguration &inputCfg,
const std::vector<std::reference_wrapper<StreamConfiguration>> &outputCfg); const std::vector<std::reference_wrapper<StreamConfiguration>>
&outputCfg) override;
int exportBuffers(const Stream *stream, unsigned int count, int exportBuffers(const Stream *stream, unsigned int count,
std::vector<std::unique_ptr<FrameBuffer>> *buffers); std::vector<std::unique_ptr<FrameBuffer>> *buffers) override;
int start(); int start() override;
void stop(); void stop() override;
int queueBuffers(FrameBuffer *input, int queueBuffers(FrameBuffer *input,
const std::map<const Stream *, FrameBuffer *> &outputs); const std::map<const Stream *, FrameBuffer *> &outputs) override;
int setInputCrop(const Stream *stream, Rectangle *rect); int setInputCrop(const Stream *stream, Rectangle *rect) override;
std::pair<Rectangle, Rectangle> inputCropBounds(const Stream *stream); std::pair<Rectangle, Rectangle> inputCropBounds(const Stream *stream) override;
private: private:
class V4L2M2MStream : protected Loggable class V4L2M2MStream : protected Loggable