NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

ipa: rkisp1: Add support of Black Level Correction tuning

Browse source 
Get the Black Level Correction algorithm parameters from YAML tuning
data.

Signed-off-by: Florian Sylvestre <fsylvestre@baylibre.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Florian Sylvestre 2022-06-17 11:23:15 +02:00 • committed by Laurent Pinchart
parent e7ec7d4de1
commit 3fa79cc688
2 changed files with 50 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

49
src/ipa/rkisp1/algorithms/blc.cpp
View file

@ -7,6 +7,10 @@
#include "blc.h" #include "blc.h"
#include <libcamera/base/log.h>
#include "libcamera/internal/yaml_parser.h"
/** /**
* \file blc.h * \file blc.h
*/ */
@ -29,6 +33,35 @@ namespace ipa::rkisp1::algorithms {
* isn't currently supported. * isn't currently supported.
*/ */
LOG_DEFINE_CATEGORY(RkISP1Blc)
BlackLevelCorrection::BlackLevelCorrection()
: tuningParameters_(false)
{
}
/**
* \copydoc libcamera::ipa::Algorithm::init
*/
int BlackLevelCorrection::init([[maybe_unused]] IPAContext &context,
const YamlObject &tuningData)
{
blackLevelRed_ = tuningData["R"].get<int16_t>(256);
blackLevelGreenR_ = tuningData["Gr"].get<int16_t>(256);
blackLevelGreenB_ = tuningData["Gb"].get<int16_t>(256);
blackLevelBlue_ = tuningData["B"].get<int16_t>(256);
tuningParameters_ = true;
LOG(RkISP1Blc, Debug)
<< "Black levels: red " << blackLevelRed_
<< ", green (red) " << blackLevelGreenR_
<< ", green (blue) " << blackLevelGreenB_
<< ", blue " << blackLevelBlue_;
return 0;
}
/** /**
* \copydoc libcamera::ipa::Algorithm::prepare * \copydoc libcamera::ipa::Algorithm::prepare
*/ */
@ -37,15 +70,15 @@ void BlackLevelCorrection::prepare(IPAContext &context,
{ {
if (context.frameContext.frameCount > 0) if (context.frameContext.frameCount > 0)
return; return;
/*
* Substract fixed values taken from imx219 tuning file. if (!tuningParameters_)
* \todo Use a configuration file for it ? return;
*/
params->others.bls_config.enable_auto = 0; params->others.bls_config.enable_auto = 0;
params->others.bls_config.fixed_val.r = 256; params->others.bls_config.fixed_val.r = blackLevelRed_;
params->others.bls_config.fixed_val.gr = 256; params->others.bls_config.fixed_val.gr = blackLevelGreenR_;
params->others.bls_config.fixed_val.gb = 256; params->others.bls_config.fixed_val.gb = blackLevelGreenB_;
params->others.bls_config.fixed_val.b = 256; params->others.bls_config.fixed_val.b = blackLevelBlue_;
params->module_en_update |= RKISP1_CIF_ISP_MODULE_BLS; params->module_en_update |= RKISP1_CIF_ISP_MODULE_BLS;
params->module_ens |= RKISP1_CIF_ISP_MODULE_BLS; params->module_ens |= RKISP1_CIF_ISP_MODULE_BLS;

10
src/ipa/rkisp1/algorithms/blc.h
View file

@ -20,10 +20,18 @@ namespace ipa::rkisp1::algorithms {
class BlackLevelCorrection : public Algorithm class BlackLevelCorrection : public Algorithm
{ {
public: public:
BlackLevelCorrection() = default; BlackLevelCorrection();
~BlackLevelCorrection() = default; ~BlackLevelCorrection() = default;
int init(IPAContext &context, const YamlObject &tuningData) override;
void prepare(IPAContext &context, rkisp1_params_cfg *params) override; void prepare(IPAContext &context, rkisp1_params_cfg *params) override;
private:
bool tuningParameters_;
int16_t blackLevelRed_;
int16_t blackLevelGreenR_;
int16_t blackLevelGreenB_;
int16_t blackLevelBlue_;
}; };
} /* namespace ipa::rkisp1::algorithms */ } /* namespace ipa::rkisp1::algorithms */