NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

src: ipa: raspberrypi: Improve behaviour when AE disabled

Browse source 
AE/AGC "disabled" is now handled better by the algorithm for itself,
so it no longer needs to be "resumed" before setting fixed shutter or
gain values.

Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
David Plowman 2020-12-01 17:55:34 +00:00 • committed by Laurent Pinchart
parent 4db11b5725
commit 472d3d3cdb
1 changed files with 0 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/ipa/raspberrypi/raspberrypi.cpp
View file

@ -512,10 +512,6 @@ void IPARPi::queueRequest(const ControlList &controls)
/* This expects units of micro-seconds. */
agc->SetFixedShutter(ctrl.second.get<int32_t>());
/* For the manual values to take effect, AGC must be unpaused. */
if (agc->IsPaused())
agc->Resume();
libcameraMetadata_.set(controls::ExposureTime, ctrl.second.get<int32_t>());
break;
}
@ -526,10 +522,6 @@ void IPARPi::queueRequest(const ControlList &controls)
ASSERT(agc);
agc->SetFixedAnalogueGain(ctrl.second.get<float>());
/* For the manual values to take effect, AGC must be unpaused. */
if (agc->IsPaused())
agc->Resume();
libcameraMetadata_.set(controls::AnalogueGain,
ctrl.second.get<float>());
break;