NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

utils: checkstyle.py: Don't run commit title checker on staged commits

Browse source 
When creating a new commit, there is no title, so the title checker
complains that the title isn't compliant and the commit cannot be
created if checkstyle is run as a pre-commit hook. Fix this by skipping
the title checker when run on staged changes.

Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Paul Elder 2023-02-27 21:11:43 +09:00
parent 58e0b6e18c
commit 51396ab512
1 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
utils/checkstyle.py
View file

@ -360,6 +360,11 @@ class TitleChecker(CommitChecker):
def check(cls, commit, top_level):
title = commit.title
# Skip the check when validating staged changes (as done through a
# pre-commit hook) as there is no title to check in that case.
if isinstance(commit, StagedChanges):
return []
# Ignore release commits, they don't need a prefix.
if TitleChecker.release_regex.fullmatch(title):
return []