NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

android: Replace ThreadRPC with blocking method call

Browse source 
Use the newly introduced InvocationTypeBlocking message type to replace
the blocking message delivery implemented with the ThreadRPC class in the
Android camera HAL.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
This commit is contained in:
Jacopo Mondi 2019-10-27 02:01:08 +01:00 • committed by Laurent Pinchart
parent 1f1d27cc14
commit 53eab99680
7 changed files with 11 additions and 118 deletions
Download patch file Download diff file Expand all files Collapse all files

21
src/android/camera_proxy.cpp
View file

@ -16,7 +16,6 @@
#include "utils.h"
#include "camera_device.h"
#include "thread_rpc.h"
using namespace libcamera;
@ -148,10 +147,8 @@ int CameraProxy::open(const hw_module_t *hardwareModule)
void CameraProxy::close()
{
ThreadRpc rpcRequest;
rpcRequest.tag = ThreadRpc::Close;
threadRpcCall(rpcRequest);
cameraDevice_->invokeMethod(&CameraDevice::close,
ConnectionTypeBlocking);
}
void CameraProxy::initialize(const camera3_callback_ops_t *callbacks)
@ -176,18 +173,8 @@ int CameraProxy::configureStreams(camera3_stream_configuration_t *stream_list)
int CameraProxy::processCaptureRequest(camera3_capture_request_t *request)
{
ThreadRpc rpcRequest;
rpcRequest.tag = ThreadRpc::ProcessCaptureRequest;
rpcRequest.request = request;
threadRpcCall(rpcRequest);
cameraDevice_->invokeMethod(&CameraDevice::processCaptureRequest,
ConnectionTypeBlocking, request);
return 0;
}
void CameraProxy::threadRpcCall(ThreadRpc &rpcRequest)
{
cameraDevice_->invokeMethod(&CameraDevice::call, ConnectionTypeQueued,
&rpcRequest);
rpcRequest.waitDelivery();
}