NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libcamera: request: Avoid double map lookup

Browse source 
Use `try_emplace()` that more or less combines `find()` and `operator[]`
in one function.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Barnabás Pőcze 2024-12-06 18:46:46 +01:00
parent 7fd317adf0
commit 5553efc6b1
1 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/libcamera/request.cpp
View file

@ -484,15 +484,14 @@ int Request::addBuffer(const Stream *stream, FrameBuffer *buffer,
return -EEXIST;
}
auto it = bufferMap_.find(stream);
if (it != bufferMap_.end()) {
auto [it, inserted] = bufferMap_.try_emplace(stream, buffer);
if (!inserted) {
LOG(Request, Error) << "FrameBuffer already set for stream";
return -EEXIST;
}
buffer->_d()->setRequest(this);
_d()->pending_.insert(buffer);
bufferMap_[stream] = buffer;
if (fence && fence->isValid())
buffer->_d()->setFence(std::move(fence));