From 5621ac27a2c639c8e84f8c838486c8eaf72f3d74 Mon Sep 17 00:00:00 2001 From: Antoine Bouyer Date: Wed, 4 Jun 2025 15:14:03 +0200 Subject: [PATCH] pipeline: imx8-isi: Fix match returned value in error case MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The match() function returns a boolean type, while it could return int in case of error when opening the capture file. Fixes: 0ec982d21086 ("libcamera: pipeline: Add IMX8 ISI pipeline") Signed-off-by: Antoine Bouyer Reviewed-by: Barnabás Pőcze Reviewed-by: Laurent Pinchart Signed-off-by: Laurent Pinchart --- src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp index c393319de..b81e436b2 100644 --- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp +++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp @@ -1003,7 +1003,7 @@ bool PipelineHandlerISI::match(DeviceEnumerator *enumerator) ret = capture->open(); if (ret) - return ret; + return false; pipes_.push_back({ std::move(isi), std::move(capture) }); }