NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

android: camera_stream: Protect buffers initialization by mutex_

Browse source 
The initialization on buffers_ in CameraStrean::configure() is not
protected by mutex_. It is no problem because configure() is not
invoked simultaneously while other functions are called. This
protects it to keep the thread safety consistency for buffers access.

Signed-off-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Hirokazu Honda 2021-12-01 16:53:44 +09:00 • committed by Laurent Pinchart
parent d5fb676ed5
commit 5e0d3a3517
1 changed files with 1 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/android/camera_stream.cpp
View file

@ -125,6 +125,7 @@ int CameraStream::configure()
if (ret < 0) if (ret < 0)
return ret; return ret;
MutexLocker lock(*mutex_);
/* Save a pointer to the reserved frame buffers */ /* Save a pointer to the reserved frame buffers */
for (const auto &frameBuffer : allocator_->buffers(stream())) for (const auto &frameBuffer : allocator_->buffers(stream()))
buffers_.push_back(frameBuffer.get()); buffers_.push_back(frameBuffer.get());