NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libcamera: pipeline: virtual: Demote config file error message to debug

Browse source 
The virtual pipeline handler prints an error message when its
configuration file can't be opened. Not providing a configuration file
is the default method to disable virtual cameras, so this error is
confusing for users. Replace it with a debug message when the
configuration file is not found, and keep an error message when it
exists but can't be opened.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Tested-by: Julien Vuillaumier <julien.vuillaumier@nxp.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Laurent Pinchart 2025-01-10 04:21:42 +02:00
parent 31a7378c87
commit 6841ea8d36
1 changed files with 11 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/libcamera/pipeline/virtual/virtual.cpp
View file

@ -329,10 +329,17 @@ bool PipelineHandlerVirtual::match([[maybe_unused]] DeviceEnumerator *enumerator
created_ = true;
File file(configurationFile("virtual", "virtual.yaml"));
bool isOpen = file.open(File::OpenModeFlag::ReadOnly);
if (!isOpen) {
LOG(Virtual, Error) << "Failed to open config file: " << file.fileName();
std::string configFile = configurationFile("virtual", "virtual.yaml", true);
if (configFile.empty()) {
LOG(Virtual, Debug)
<< "Configuration file not found, skipping virtual cameras";
return false;
}
File file(configFile);
if (!file.open(File::OpenModeFlag::ReadOnly)) {
LOG(Virtual, Error)
<< "Failed to open config file `" << file.fileName() << "`";
return false;
}