NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libipa: awb: Pass lux value to calculateAwb() as unsigned int

Browse source 
The lux value can never be negative. Pass it as an unsigned int.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Stefan Klug <stefan.klug@ideasonboard.com>
This commit is contained in:
Laurent Pinchart 2025-02-23 23:12:40 +02:00
parent 1a948d5457
commit 6981a5169b
5 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/ipa/libipa/awb.h
View file

@ -35,7 +35,7 @@ public:
virtual ~AwbAlgorithm() = default; virtual ~AwbAlgorithm() = default;
virtual int init(const YamlObject &tuningData) = 0; virtual int init(const YamlObject &tuningData) = 0;
virtual AwbResult calculateAwb(const AwbStats &stats, int lux) = 0; virtual AwbResult calculateAwb(const AwbStats &stats, unsigned int lux) = 0;
virtual RGB<double> gainsFromColourTemperature(double colourTemperature) = 0; virtual RGB<double> gainsFromColourTemperature(double colourTemperature) = 0;
const ControlInfoMap::Map &controls() const const ControlInfoMap::Map &controls() const

2
src/ipa/libipa/awb_bayes.cpp
View file

@ -275,7 +275,7 @@ RGB<double> AwbBayes::gainsFromColourTemperature(double colourTemperature)
return { { gains[0], 1.0, gains[1] } }; return { { gains[0], 1.0, gains[1] } };
} }
AwbResult AwbBayes::calculateAwb(const AwbStats &stats, int lux) AwbResult AwbBayes::calculateAwb(const AwbStats &stats, unsigned int lux)
{ {
ipa::Pwl prior; ipa::Pwl prior;
if (lux > 0) { if (lux > 0) {

2
src/ipa/libipa/awb_bayes.h
View file

@ -34,7 +34,7 @@ public:
AwbBayes() = default; AwbBayes() = default;
int init(const YamlObject &tuningData) override; int init(const YamlObject &tuningData) override;
AwbResult calculateAwb(const AwbStats &stats, int lux) override; AwbResult calculateAwb(const AwbStats &stats, unsigned int lux) override;
RGB<double> gainsFromColourTemperature(double temperatureK) override; RGB<double> gainsFromColourTemperature(double temperatureK) override;
void handleControls(const ControlList &controls) override; void handleControls(const ControlList &controls) override;

2
src/ipa/libipa/awb_grey.cpp
View file

@ -70,7 +70,7 @@ int AwbGrey::init(const YamlObject &tuningData)
* *
* \return The AWB result * \return The AWB result
*/ */
AwbResult AwbGrey::calculateAwb(const AwbStats &stats, [[maybe_unused]] int lux) AwbResult AwbGrey::calculateAwb(const AwbStats &stats, [[maybe_unused]] unsigned int lux)
{ {
AwbResult result; AwbResult result;
auto means = stats.getRGBMeans(); auto means = stats.getRGBMeans();

2
src/ipa/libipa/awb_grey.h
View file

@ -23,7 +23,7 @@ public:
AwbGrey() = default; AwbGrey() = default;
int init(const YamlObject &tuningData) override; int init(const YamlObject &tuningData) override;
AwbResult calculateAwb(const AwbStats &stats, int lux) override; AwbResult calculateAwb(const AwbStats &stats, unsigned int lux) override;
RGB<double> gainsFromColourTemperature(double colourTemperature) override; RGB<double> gainsFromColourTemperature(double colourTemperature) override;
private: private: